re-use logic for http client configuration

zeitlinger · zeitlinger · commit 466cd05f3782 · 2024-06-18T21:16:34.000+02:00
diff --git a/instrumentation/apache-httpclient/apache-httpclient-4.3/library/src/main/java/io/opentelemetry/instrumentation/apachehttpclient/v4_3/ApacheHttpClientTelemetryBuilder.java b/instrumentation/apache-httpclient/apache-httpclient-4.3/library/src/main/java/io/opentelemetry/instrumentation/apachehttpclient/v4_3/ApacheHttpClientTelemetryBuilder.java
@@ -18,7 +18,7 @@ public final class ApacheHttpClientTelemetryBuilder
   private static final String INSTRUMENTATION_NAME = "io.opentelemetry.apache-httpclient-4.3";
 
   ApacheHttpClientTelemetryBuilder(OpenTelemetry openTelemetry) {
-    super(instrumentationName, openTelemetry, ApacheHttpClientHttpAttributesGetter.INSTANCE);
+    super(INSTRUMENTATION_NAME, openTelemetry, ApacheHttpClientHttpAttributesGetter.INSTANCE);
   }
 
   /**
diff --git a/instrumentation/spring/spring-web/spring-web-3.1/library/src/main/java/io/opentelemetry/instrumentation/spring/web/v3_1/SpringWebTelemetryBuilder.java b/instrumentation/spring/spring-web/spring-web-3.1/library/src/main/java/io/opentelemetry/instrumentation/spring/web/v3_1/SpringWebTelemetryBuilder.java
@@ -16,7 +16,7 @@ public final class SpringWebTelemetryBuilder
   private static final String INSTRUMENTATION_NAME = "io.opentelemetry.spring-web-3.1";
 
   SpringWebTelemetryBuilder(OpenTelemetry openTelemetry) {
-    super(instrumentationName, openTelemetry, SpringWebHttpAttributesGetter.INSTANCE);
+    super(INSTRUMENTATION_NAME, openTelemetry, SpringWebHttpAttributesGetter.INSTANCE);
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ public final class ApacheHttpClientTelemetryBuilder`
`18`	`18`	`private static final String INSTRUMENTATION_NAME = "io.opentelemetry.apache-httpclient-4.3";`
`19`	`19`
`20`	`20`	`ApacheHttpClientTelemetryBuilder(OpenTelemetry openTelemetry) {`
`21`		`- super(instrumentationName, openTelemetry, ApacheHttpClientHttpAttributesGetter.INSTANCE);`
	`21`	`+ super(INSTRUMENTATION_NAME, openTelemetry, ApacheHttpClientHttpAttributesGetter.INSTANCE);`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ public final class SpringWebTelemetryBuilder`
`16`	`16`	`private static final String INSTRUMENTATION_NAME = "io.opentelemetry.spring-web-3.1";`
`17`	`17`
`18`	`18`	`SpringWebTelemetryBuilder(OpenTelemetry openTelemetry) {`
`19`		`- super(instrumentationName, openTelemetry, SpringWebHttpAttributesGetter.INSTANCE);`
	`19`	`+ super(INSTRUMENTATION_NAME, openTelemetry, SpringWebHttpAttributesGetter.INSTANCE);`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`/**`