Call getInitialProps on Component when it’s not defined on App #9287

timneutkens · 2019-11-02T12:03:39Z

ijjk · 2019-11-02T12:09:03Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
buildDuration	14.2s	14s	-193ms
nodeModulesSize	48.6 MB	48.5 MB	-77.5 kB

Client Bundles (main, webpack, commons) Overall decrease ✓

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
main-HASH.js	16.6 kB	16.6 kB	-15 B
main-HASH.js gzip	5.87 kB	5.86 kB	-7 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..7459734ec.js	20.1 kB	N/A	N/A
16b1a7225520..34ec.js gzip	7.38 kB	N/A	N/A
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..f81b4213a.js	28.6 kB	N/A	N/A
de003c3a9d30..213a.js gzip	10.8 kB	N/A	N/A
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
16b1a7225520..63e75d588.js	N/A	19.7 kB	N/A
16b1a7225520..d588.js gzip	N/A	7.23 kB	N/A
de003c3a9d30..22c8c27f2.js	N/A	28.7 kB	N/A
de003c3a9d30..27f2.js gzip	N/A	10.9 kB	N/A
Overall change	214 kB	214 kB	-15 B

Client Bundles (main, webpack, commons) Modern Overall decrease ✓

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
main-HASH.module.js	14.1 kB	14.1 kB	-15 B
main-HASH.module.js gzip	5.29 kB	5.28 kB	-7 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..0d.module.js	16.2 kB	N/A	N/A
16b1a7225520..dule.js gzip	6.22 kB	N/A	N/A
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..82.module.js	22.1 kB	N/A	N/A
de003c3a9d30..dule.js gzip	8.68 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
16b1a7225520..51.module.js	N/A	15.8 kB	N/A
16b1a7225520..dule.js gzip	N/A	6.07 kB	N/A
de003c3a9d30..75.module.js	N/A	22.2 kB	N/A
de003c3a9d30..dule.js gzip	N/A	8.7 kB	N/A
Overall change	192 kB	192 kB	-15 B

Client Pages

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
_app.module.js	1.54 kB	1.54 kB	✓
_app.module.js gzip	759 B	759 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.49 kB	5.49 kB	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.2 kB	20.2 kB	✓

Client Build Manifests

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	201 B	199 B	-2 B
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	210 B	⚠️ +1 B
Overall change	495 B	495 B	✓

Rendered Page Sizes Overall decrease ✓

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
index.html	4.06 kB	3.94 kB	-115 B
index.html gzip	1.04 kB	1 kB	-34 B
link.html	4.58 kB	4.47 kB	-115 B
link.html gzip	1.12 kB	1.08 kB	-36 B
withRouter.html	4.59 kB	4.47 kB	-115 B
withRouter.html gzip	1.1 kB	1.07 kB	-35 B
Overall change	13.2 kB	12.9 kB	-345 B

Diffs

Diff for main-HASH.js

@@ -289,7 +289,7 @@ var _inherits = __webpack_require__("N9n2");
 
 var _slicedToArray = __webpack_require__("8+Nu");
 
-var _interopRequireWildcard3 = __webpack_require__("5Uuq");
+var _interopRequireWildcard = __webpack_require__("5Uuq");
 
 var _interopRequireDefault = __webpack_require__("KI45");
 
@@ -302,8 +302,6 @@ var _asyncToGenerator2 = _interopRequireDefault(__webpack_require__("+oT+"));
 
 var _extends2 = _interopRequireDefault(__webpack_require__("htGi"));
 
-var _interopRequireWildcard2 = _interopRequireDefault(__webpack_require__("5Uuq"));
-
 var _promise = _interopRequireDefault(__webpack_require__("eVuF"));
 
 var _react = _interopRequireDefault(__webpack_require__("q1tI"));
@@ -320,7 +318,7 @@ var _utils = __webpack_require__("g/15");
 
 var _pageLoader = _interopRequireDefault(__webpack_require__("zmvN"));
 
-var envConfig = _interopRequireWildcard3(__webpack_require__("yLiY"));
+var envConfig = _interopRequireWildcard(__webpack_require__("yLiY"));
 
 var _headManagerContext = __webpack_require__("FYa8");
 
@@ -342,7 +340,7 @@ if (!window.Promise) {
 
 var data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-var version = "9.1.3-canary.1";
+var version = "9.1.3-canary.0";
 exports.version = version;
 var props = data.props,
     err = data.err,
@@ -412,12 +410,9 @@ function (_react$default$Compon) {
   }, {
     key: "componentDidMount",
     value: function componentDidMount() {
-      this.scrollToHash();
-
-      if (false) {} // If page was exported and has a querystring
+      this.scrollToHash(); // If page was exported and has a querystring
       // If it's a dynamic route or has a querystring
 
-
       if (data.nextExport && ((0, _isDynamic.isDynamicRoute)(router.pathname) || location.search || data.skeleton)) {
         // update query on mount for exported pages
         router.replace(router.pathname + '?' + (0, _querystring.stringify)((0, _extends2["default"])({}, router.query, {}, (0, _querystring.parse)(location.search.substr(1)))), asPath, {
@@ -560,10 +555,7 @@ function () {
                   emitter: emitter
                 });
               }
-            }); // call init-client middleware
-
-            if (false) {}
-
+            });
             renderCtx = {
               App: App,
               Component: Component,
@@ -574,7 +566,7 @@ function () {
             render(renderCtx);
             return _context.abrupt("return", emitter);
 
-          case 31:
+          case 30:
           case "end":
             return _context.stop();
         }
@@ -667,14 +659,12 @@ function _renderError() {
             return _context3.abrupt("return", webpackHMR.reportRuntimeError(webpackHMR.prepareError(err)));
 
           case 3:
-            if (false) {} // Make sure we log the error to the console, otherwise users can't track down issues.
-
-
+            // Make sure we log the error to the console, otherwise users can't track down issues.
             console.error(err);
-            _context3.next = 7;
+            _context3.next = 6;
             return pageLoader.loadPage('/_error');
 
-          case 7:
+          case 6:
             exports.ErrorComponent = ErrorComponent = _context3.sent;
             // In production we do a normal render with the `ErrorComponent` as component.
             // If we've gotten here upon initial render, we can use the props from the server.
@@ -694,31 +684,31 @@ function _renderError() {
             };
 
             if (!props.props) {
-              _context3.next = 14;
+              _context3.next = 13;
               break;
             }
 
             _context3.t0 = props.props;
-            _context3.next = 17;
+            _context3.next = 16;
             break;
 
-          case 14:
-            _context3.next = 16;
+          case 13:
+            _context3.next = 15;
             return (0, _utils.loadGetInitialProps)(App, appCtx);
 
-          case 16:
+          case 15:
             _context3.t0 = _context3.sent;
 
-          case 17:
+          case 16:
             initProps = _context3.t0;
-            _context3.next = 20;
+            _context3.next = 19;
             return doRender((0, _extends2["default"])({}, props, {
               err: err,
               Component: ErrorComponent,
               props: initProps
             }));
 
-          case 20:
+          case 19:
           case "end":
             return _context3.stop();
         }

Diff for main-HASH.module.js

@@ -288,7 +288,7 @@ exports.HeadManagerContext = React.createContext(null);
 "use strict";
 
 
-var _interopRequireWildcard3 = __webpack_require__("5Uuq");
+var _interopRequireWildcard = __webpack_require__("5Uuq");
 
 var _interopRequireDefault = __webpack_require__("KI45");
 
@@ -301,8 +301,6 @@ var _asyncToGenerator2 = _interopRequireDefault(__webpack_require__("+oT+"));
 
 var _extends2 = _interopRequireDefault(__webpack_require__("htGi"));
 
-var _interopRequireWildcard2 = _interopRequireDefault(__webpack_require__("5Uuq"));
-
 var _promise = _interopRequireDefault(__webpack_require__("eVuF"));
 
 var _react = _interopRequireDefault(__webpack_require__("q1tI"));
@@ -319,7 +317,7 @@ var _utils = __webpack_require__("g/15");
 
 var _pageLoader = _interopRequireDefault(__webpack_require__("zmvN"));
 
-var envConfig = _interopRequireWildcard3(__webpack_require__("yLiY"));
+var envConfig = _interopRequireWildcard(__webpack_require__("yLiY"));
 
 var _headManagerContext = __webpack_require__("FYa8");
 
@@ -341,7 +339,7 @@ if (!window.Promise) {
 
 var data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-var version = "9.1.3-canary.1";
+var version = "9.1.3-canary.0";
 exports.version = version;
 var {
   props,
@@ -397,12 +395,9 @@ class Container extends _react.default.Component {
   }
 
   componentDidMount() {
-    this.scrollToHash();
-
-    if (false) {} // If page was exported and has a querystring
+    this.scrollToHash(); // If page was exported and has a querystring
     // If it's a dynamic route or has a querystring
 
-
     if (data.nextExport && ((0, _isDynamic.isDynamicRoute)(router.pathname) || location.search || data.skeleton)) {
       // update query on mount for exported pages
       router.replace(router.pathname + '?' + (0, _querystring.stringify)((0, _extends2.default)({}, router.query, {}, (0, _querystring.parse)(location.search.substr(1)))), asPath, {
@@ -507,10 +502,7 @@ function () {
           emitter
         });
       }
-    }); // call init-client middleware
-
-    if (false) {}
-
+    });
     var renderCtx = {
       App,
       Component,
@@ -567,8 +559,6 @@ function _renderError() {
     } = props; // In development runtime errors are caught by react-error-overlay
     // In production we catch runtime errors using componentDidCatch which will trigger renderError
 
-    if (false) {}
-
     if (false) {} // Make sure we log the error to the console, otherwise users can't track down issues.

Diff for _buildManifest.js

@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.a9e45275d81f65ce1b3a.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file

Diff for _buildManifest.module.js

@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file

Diff for index.html

@@ -12,13 +12,13 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-6664b64e499fca4460ff.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-f59e55f2f069a03aa793.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.89ebf3e33b855a0478ce.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d20ed0d48b1c6adab54d.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.599798f54283a1d786c2.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -31,7 +31,6 @@
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script crossorigin="anonymous" nomodule="" src="/_next/static/runtime/polyfills-46d78823406a20028351.js"></script>
         <script async="" data-next-page="/" src="/_next/static/BUILD_ID/pages/index.js"
         crossorigin="anonymous" nomodule=""></script>
         <script async="" data-next-page="/" src="/_next/static/BUILD_ID/pages/index.module.js"
@@ -44,9 +43,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-108e86883c2fd794bd5c.js"
+        <script src="/_next/static/runtime/main-30f56449cfbe7044b21b.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-6664b64e499fca4460ff.module.js"
+        <script src="/_next/static/runtime/main-f59e55f2f069a03aa793.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.219514909c9db8a9ff76.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -58,9 +57,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.89ebf3e33b855a0478ce.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4060260e2de139dbd214.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.e98dd1b8c3b350a21af3.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d20ed0d48b1c6adab54d.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.599798f54283a1d786c2.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for link.html

@@ -16,11 +16,11 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.89ebf3e33b855a0478ce.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d20ed0d48b1c6adab54d.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.599798f54283a1d786c2.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
+        <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-6664b64e499fca4460ff.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-f59e55f2f069a03aa793.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -36,7 +36,6 @@
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script crossorigin="anonymous" nomodule="" src="/_next/static/runtime/polyfills-46d78823406a20028351.js"></script>
         <script async="" data-next-page="/link" src="/_next/static/BUILD_ID/pages/link.js"
         crossorigin="anonymous" nomodule=""></script>
         <script async="" data-next-page="/link" src="/_next/static/BUILD_ID/pages/link.module.js"
@@ -59,17 +58,17 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.89ebf3e33b855a0478ce.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4060260e2de139dbd214.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.e98dd1b8c3b350a21af3.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d20ed0d48b1c6adab54d.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.599798f54283a1d786c2.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.a9e45275d81f65ce1b3a.js"
+        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
+        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-108e86883c2fd794bd5c.js"
+        <script src="/_next/static/runtime/main-30f56449cfbe7044b21b.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-6664b64e499fca4460ff.module.js"
+        <script src="/_next/static/runtime/main-f59e55f2f069a03aa793.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for withRouter.html

@@ -16,11 +16,11 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.89ebf3e33b855a0478ce.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d20ed0d48b1c6adab54d.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.599798f54283a1d786c2.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
+        <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-6664b64e499fca4460ff.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-f59e55f2f069a03aa793.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -34,7 +34,6 @@
         <script crossorigin="anonymous" nomodule="">
             !function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")||!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();
         </script>
-        <script crossorigin="anonymous" nomodule="" src="/_next/static/runtime/polyfills-46d78823406a20028351.js"></script>
         <script async="" data-next-page="/withRouter" src="/_next/static/BUILD_ID/pages/withRouter.js"
         crossorigin="anonymous" nomodule=""></script>
         <script async="" data-next-page="/withRouter" src="/_next/static/BUILD_ID/pages/withRouter.module.js"
@@ -57,17 +56,17 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.89ebf3e33b855a0478ce.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4060260e2de139dbd214.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.e98dd1b8c3b350a21af3.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d20ed0d48b1c6adab54d.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.599798f54283a1d786c2.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.a9e45275d81f65ce1b3a.js"
+        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.b45ed1163cffb8de5382.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
+        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.6676b8996c653de03131.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-108e86883c2fd794bd5c.js"
+        <script src="/_next/static/runtime/main-30f56449cfbe7044b21b.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-6664b64e499fca4460ff.module.js"
+        <script src="/_next/static/runtime/main-f59e55f2f069a03aa793.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
buildDuration	14.1s	14.2s	⚠️ +100ms
nodeModulesSize	48.6 MB	48.5 MB	-77.5 kB

Client Bundles (main, webpack, commons) Overall decrease ✓

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
main-HASH.js	16.6 kB	16.6 kB	-15 B
main-HASH.js gzip	5.87 kB	5.86 kB	-7 B
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..7459734ec.js	20.1 kB	N/A	N/A
16b1a7225520..34ec.js gzip	7.38 kB	N/A	N/A
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..f81b4213a.js	28.6 kB	N/A	N/A
de003c3a9d30..213a.js gzip	10.8 kB	N/A	N/A
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
16b1a7225520..63e75d588.js	N/A	19.7 kB	N/A
16b1a7225520..d588.js gzip	N/A	7.23 kB	N/A
de003c3a9d30..22c8c27f2.js	N/A	28.7 kB	N/A
de003c3a9d30..27f2.js gzip	N/A	10.9 kB	N/A
Overall change	214 kB	214 kB	-15 B

Client Bundles (main, webpack, commons) Modern Overall decrease ✓

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
main-HASH.module.js	14.1 kB	14.1 kB	-15 B
main-HASH.module.js gzip	5.29 kB	5.28 kB	-7 B
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..0d.module.js	16.2 kB	N/A	N/A
16b1a7225520..dule.js gzip	6.22 kB	N/A	N/A
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..82.module.js	22.1 kB	N/A	N/A
de003c3a9d30..dule.js gzip	8.68 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
16b1a7225520..51.module.js	N/A	15.8 kB	N/A
16b1a7225520..dule.js gzip	N/A	6.07 kB	N/A
de003c3a9d30..75.module.js	N/A	22.2 kB	N/A
de003c3a9d30..dule.js gzip	N/A	8.7 kB	N/A
Overall change	192 kB	192 kB	-15 B

Client Pages

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
_app.module.js	1.54 kB	1.54 kB	✓
_app.module.js gzip	759 B	759 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.49 kB	5.49 kB	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.2 kB	20.2 kB	✓

Client Build Manifests

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	201 B	199 B	-2 B
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	210 B	⚠️ +1 B
Overall change	495 B	495 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
_error.js	248 kB	241 kB	-6.22 kB
_error.js gzip	65.6 kB	64.4 kB	-1.14 kB
hooks.html	4.19 kB	4.08 kB	-115 B
hooks.html gzip	1.07 kB	1.03 kB	-37 B
index.js	248 kB	242 kB	-6.29 kB
index.js gzip	65.7 kB	64.5 kB	-1.21 kB
link.js	280 kB	274 kB	-6.18 kB
link.js gzip	74.7 kB	73.5 kB	-1.14 kB
routerDirect.js	273 kB	267 kB	-6.18 kB
routerDirect.js gzip	72.7 kB	71.6 kB	-1.16 kB
withRouter.js	273 kB	267 kB	-6.18 kB
withRouter.js gzip	72.8 kB	71.7 kB	-1.16 kB
Overall change	1.33 MB	1.3 MB	-31.2 kB

Commit: 8c1d037

Timer

LGTM!

ijjk · 2019-11-02T14:56:56Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
buildDuration	13.8s	14.2s	⚠️ +379ms
nodeModulesSize	48.6 MB	48.6 MB	⚠️ +279 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.87 kB	5.87 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..7459734ec.js	20.1 kB	20.1 kB	✓
16b1a7225520..34ec.js gzip	7.38 kB	7.38 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..f81b4213a.js	28.6 kB	N/A	N/A
de003c3a9d30..213a.js gzip	10.8 kB	N/A	N/A
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
de003c3a9d30..254ddadd9.js	N/A	28.7 kB	N/A
de003c3a9d30..add9.js gzip	N/A	10.9 kB	N/A
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
main-HASH.module.js	14.1 kB	14.1 kB	✓
main-HASH.module.js gzip	5.29 kB	5.29 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..0d.module.js	16.2 kB	16.2 kB	✓
16b1a7225520..dule.js gzip	6.22 kB	6.22 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..82.module.js	22.1 kB	N/A	N/A
de003c3a9d30..dule.js gzip	8.68 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
de003c3a9d30..36.module.js	N/A	22.2 kB	N/A
de003c3a9d30..dule.js gzip	N/A	8.71 kB	N/A
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
_app.module.js	1.54 kB	1.54 kB	✓
_app.module.js gzip	759 B	759 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.49 kB	5.49 kB	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.2 kB	20.2 kB	✓

Client Build Manifests

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	201 B	201 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Rendered Page Sizes

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
index.html	4.06 kB	4.06 kB	✓
index.html gzip	1.04 kB	1.03 kB	-3 B
link.html	4.58 kB	4.58 kB	✓
link.html gzip	1.12 kB	1.11 kB	-2 B
withRouter.html	4.59 kB	4.59 kB	✓
withRouter.html gzip	1.1 kB	1.1 kB	✓
Overall change	13.2 kB	13.2 kB	✓

Diffs

Diff for index.html

@@ -18,7 +18,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.89ebf3e33b855a0478ce.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d20ed0d48b1c6adab54d.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.dda3a797bb804537ed85.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -58,9 +58,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.89ebf3e33b855a0478ce.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4060260e2de139dbd214.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.aa9b9639e60cb81cd54f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d20ed0d48b1c6adab54d.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.dda3a797bb804537ed85.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for link.html

@@ -16,7 +16,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.89ebf3e33b855a0478ce.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d20ed0d48b1c6adab54d.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.dda3a797bb804537ed85.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
         as="script" crossorigin="anonymous" />
@@ -59,9 +59,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.89ebf3e33b855a0478ce.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4060260e2de139dbd214.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.aa9b9639e60cb81cd54f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d20ed0d48b1c6adab54d.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.dda3a797bb804537ed85.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.a9e45275d81f65ce1b3a.js"
         async="" crossorigin="anonymous" nomodule=""></script>

Diff for withRouter.html

@@ -16,7 +16,7 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.89ebf3e33b855a0478ce.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d20ed0d48b1c6adab54d.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.dda3a797bb804537ed85.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.13a61a2410d3fe9a0cb1.module.js"
         as="script" crossorigin="anonymous" />
@@ -57,9 +57,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.89ebf3e33b855a0478ce.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.4060260e2de139dbd214.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.aa9b9639e60cb81cd54f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.d20ed0d48b1c6adab54d.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.dda3a797bb804537ed85.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.a9e45275d81f65ce1b3a.js"
         async="" crossorigin="anonymous" nomodule=""></script>

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
buildDuration	14.3s	14.4s	⚠️ +112ms
nodeModulesSize	48.6 MB	48.6 MB	⚠️ +279 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
main-HASH.js	16.6 kB	16.6 kB	✓
main-HASH.js gzip	5.87 kB	5.87 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
16b1a7225520..7459734ec.js	20.1 kB	20.1 kB	✓
16b1a7225520..34ec.js gzip	7.38 kB	7.38 kB	✓
4952ddcd88e7..bfe360fe6.js	10.5 kB	10.5 kB	✓
4952ddcd88e7..0fe6.js gzip	4.06 kB	4.06 kB	✓
commons.HASH.js	11.3 kB	11.3 kB	✓
commons.HASH.js gzip	4.23 kB	4.23 kB	✓
de003c3a9d30..f81b4213a.js	28.6 kB	N/A	N/A
de003c3a9d30..213a.js gzip	10.8 kB	N/A	N/A
framework.1b..cdcfe1283.js	125 kB	125 kB	✓
framework.1b..1283.js gzip	39.4 kB	39.4 kB	✓
de003c3a9d30..254ddadd9.js	N/A	28.7 kB	N/A
de003c3a9d30..add9.js gzip	N/A	10.9 kB	N/A
Overall change	214 kB	214 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
main-HASH.module.js	14.1 kB	14.1 kB	✓
main-HASH.module.js gzip	5.29 kB	5.29 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
16b1a7225520..0d.module.js	16.2 kB	16.2 kB	✓
16b1a7225520..dule.js gzip	6.22 kB	6.22 kB	✓
4952ddcd88e7..4a.module.js	12.8 kB	12.8 kB	✓
4952ddcd88e7..dule.js gzip	4.75 kB	4.75 kB	✓
de003c3a9d30..82.module.js	22.1 kB	N/A	N/A
de003c3a9d30..dule.js gzip	8.68 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
de003c3a9d30..36.module.js	N/A	22.2 kB	N/A
de003c3a9d30..dule.js gzip	N/A	8.71 kB	N/A
Overall change	192 kB	192 kB	✓

Client Pages

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
_app.js	1.63 kB	1.63 kB	✓
_app.js gzip	788 B	788 B	✓
_error.js	12.3 kB	12.3 kB	✓
_error.js gzip	4.79 kB	4.79 kB	✓
hooks.js	1.92 kB	1.92 kB	✓
hooks.js gzip	941 B	941 B	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	5.81 kB	5.81 kB	✓
link.js gzip	2.56 kB	2.56 kB	✓
routerDirect.js	413 B	413 B	✓
routerDirect.js gzip	285 B	285 B	✓
withRouter.js	423 B	423 B	✓
withRouter.js gzip	284 B	284 B	✓
Overall change	22.8 kB	22.8 kB	✓

Client Pages Modern

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
_app.module.js	1.54 kB	1.54 kB	✓
_app.module.js gzip	759 B	759 B	✓
_error.module.js	10.5 kB	10.5 kB	✓
_error.module.js gzip	4.26 kB	4.26 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	792 B	792 B	✓
index.module.js	292 B	292 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	5.49 kB	5.49 kB	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect.module.js	399 B	399 B	✓
routerDirect..dule.js gzip	285 B	285 B	✓
withRouter.module.js	409 B	409 B	✓
withRouter.m..dule.js gzip	282 B	282 B	✓
Overall change	20.2 kB	20.2 kB	✓

Client Build Manifests

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
_buildManifest.js	244 B	244 B	✓
_buildManifest.js gzip	201 B	201 B	✓
_buildManifest.module.js	251 B	251 B	✓
_buildManife..dule.js gzip	209 B	209 B	✓
Overall change	495 B	495 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	timneutkens/next.js fix/function-component-gip	Change
_error.js	248 kB	248 kB	⚠️ +150 B
_error.js gzip	65.6 kB	65.6 kB	⚠️ +48 B
hooks.html	4.19 kB	4.19 kB	✓
hooks.html gzip	1.07 kB	1.07 kB	-2 B
index.js	248 kB	248 kB	⚠️ +150 B
index.js gzip	65.7 kB	65.8 kB	⚠️ +48 B
link.js	280 kB	280 kB	⚠️ +150 B
link.js gzip	74.7 kB	74.7 kB	⚠️ +40 B
routerDirect.js	273 kB	273 kB	⚠️ +150 B
routerDirect.js gzip	72.7 kB	72.8 kB	⚠️ +35 B
withRouter.js	273 kB	273 kB	⚠️ +150 B
withRouter.js gzip	72.8 kB	72.9 kB	⚠️ +38 B
Overall change	1.33 MB	1.33 MB	⚠️ +750 B

Commit: 0cb8f98

Call getInitialProps on Component when it’s not defined on App

8c1d037

Fixes vercel#9284

timneutkens requested review from ijjk, lfades and Timer as code owners November 2, 2019 12:03

Timer added this to the 9.1.3 milestone Nov 2, 2019

Timer added the ready to land label Nov 2, 2019

Timer approved these changes Nov 2, 2019

View reviewed changes

Merge branch 'canary' into fix/function-component-gip

0cb8f98

Timer merged commit 21f0db8 into vercel:canary Nov 2, 2019

timneutkens deleted the fix/function-component-gip branch November 2, 2019 15:12

This was referenced Nov 19, 2019

[Snyk] Upgrade next from 9.1.2 to 9.1.3 ndom91/newtelco-next-maintenance-mgmt#10

Merged

[Snyk] Upgrade next from 9.0.4 to 9.1.3 ajesse11x/now-examples#17

Open

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Call getInitialProps on Component when it’s not defined on App #9287

Call getInitialProps on Component when it’s not defined on App #9287

timneutkens commented Nov 2, 2019

ijjk commented Nov 2, 2019

Diffs

Timer left a comment

ijjk commented Nov 2, 2019

Diffs

Call getInitialProps on Component when it’s not defined on App #9287

Call getInitialProps on Component when it’s not defined on App #9287

Conversation

timneutkens commented Nov 2, 2019

ijjk commented Nov 2, 2019

Stats from current PR

Diffs

Timer left a comment

Choose a reason for hiding this comment

ijjk commented Nov 2, 2019

Stats from current PR

Diffs