Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and update with-apollo-and-redux example #9270

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

HaNdTriX
Copy link
Contributor

@HaNdTriX HaNdTriX commented Oct 31, 2019

This PR updates the with-apollo-and-redux example to use the latest changes from the examples with-apollo and with-redux.

In addition to that I added:

  • some prop-type checks
  • reduced bundle size
  • added function names
  • refactored code structure
  • fixed ssr issues
  • added some code consistency

Sorry for creating just one commit, but I didn't wanted to put too much work into this example.
Nevertheless I've tested all the changes manually!

Related

close #8830

@HaNdTriX HaNdTriX force-pushed the examples/with-apollo-and-redux branch from 763cee3 to 96f0a2a Compare October 31, 2019 14:28
@Timer Timer added this to the 9.1.3 milestone Oct 31, 2019
@Timer Timer added the examples Issue/PR related to examples label Oct 31, 2019
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I trust your work on these. 😌

@Timer Timer merged commit e09eb8d into vercel:canary Oct 31, 2019
@HaNdTriX HaNdTriX deleted the examples/with-apollo-and-redux branch October 31, 2019 14:44
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apollo & Redux example doesn't wait for data during SSR rendering
2 participants