Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow manually setting amphtml #9098

Merged
merged 10 commits into from
Oct 18, 2019
Merged

Allow manually setting amphtml #9098

merged 10 commits into from
Oct 18, 2019

Conversation

iliran11
Copy link
Contributor

@iliran11 iliran11 commented Oct 16, 2019 •
edited
Loading

Following this pull request: #8129
It is possible to set your own amphtml link. However, the original link is still being rendered. Resulting in duplication of links.

This PR fixes this. Added relevant tests - count 1 amphtml link is being rendered.

@ijjk
Copy link
Member

ijjk commented Oct 16, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary iliran11/next.js master Change
buildDuration 14s 13.6s -447ms
nodeModulesSize 48.5 MB 48.5 MB -2.81 kB
Client Bundles (main, webpack, commons) Overall decrease ✓
zeit/next.js canary iliran11/next.js master Change
main-HASH.js 18.9 kB 18.9 kB -2 B
main-HASH.js gzip 6.79 kB 6.79 kB -2 B
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..2641f57f9.js 14.9 kB N/A N/A
16b1a7225520..57f9.js gzip 5.38 kB N/A N/A
4952ddcd88e7..0fb1924cf.js 21.7 kB N/A N/A
4952ddcd88e7..24cf.js gzip 7.77 kB N/A N/A
de003c3a9d30..aab6ec1a2.js 28.6 kB N/A N/A
de003c3a9d30..c1a2.js gzip 10.8 kB N/A N/A
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
4952ddcd88e7..9dda6167a.js N/A 21.9 kB N/A
4952ddcd88e7..167a.js gzip N/A 7.81 kB N/A
de003c3a9d30..3a0560775.js N/A 43.2 kB N/A
de003c3a9d30..0775.js gzip N/A 15.5 kB N/A
Overall change 211 kB 211 kB -2 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
zeit/next.js canary iliran11/next.js master Change
main-HASH.module.js 17.2 kB 17.2 kB -2 B
main-HASH.module.js gzip 6.52 kB 6.52 kB -2 B
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..3e.module.js 10.8 kB N/A N/A
16b1a7225520..dule.js gzip 4.05 kB N/A N/A
de003c3a9d30..e6.module.js 34.8 kB N/A N/A
de003c3a9d30..dule.js gzip 12.9 kB N/A N/A
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
de003c3a9d30..72.module.js N/A 45.6 kB N/A
de003c3a9d30..dule.js gzip N/A 16.5 kB N/A
Overall change 190 kB 190 kB -2 B
Client Pages Overall decrease ✓
zeit/next.js canary iliran11/next.js master Change
_app.js 1.63 kB 1.81 kB ⚠️ +184 B
_app.js gzip 786 B 873 B ⚠️ +87 B
_error.js 12.2 kB 12 kB -183 B
_error.js gzip 4.78 kB 4.73 kB -46 B
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB -1 B
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB -2 B
link.js gzip 3.5 kB 3.5 kB -2 B
routerDirect.js 411 B 408 B -3 B
routerDirect.js gzip 283 B 281 B -2 B
withRouter.js 421 B 419 B -2 B
withRouter.js gzip 282 B 280 B -2 B
Overall change 35.9 kB 35.8 kB -6 B
Client Pages Modern Overall increase ⚠️
zeit/next.js canary iliran11/next.js master Change
_app.module.js 1.54 kB 1.7 kB ⚠️ +160 B
_app.module.js gzip 754 B 832 B ⚠️ +78 B
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 794 B 793 B -1 B
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB -2 B
link.module.js gzip 3.68 kB 3.68 kB -1 B
routerDirect.module.js 396 B 394 B -2 B
routerDirect..dule.js gzip 283 B 281 B -2 B
withRouter.module.js 407 B 404 B -3 B
withRouter.m..dule.js gzip 281 B 278 B -3 B
Overall change 35.9 kB 36.1 kB ⚠️ +153 B
Client Build Manifests Overall decrease ✓
zeit/next.js canary iliran11/next.js master Change
_buildManifest.js 244 B 81 B -163 B
_buildManifest.js gzip 199 B 61 B -138 B
_buildManifest.module.js 251 B 81 B -170 B
_buildManife..dule.js gzip 209 B 61 B -148 B
Overall change 495 B 162 B -333 B
Rendered Page Sizes Overall decrease ✓
zeit/next.js canary iliran11/next.js master Change
index.html 3.5 kB 3.62 kB ⚠️ +112 B
index.html gzip 944 B 946 B ⚠️ +2 B
link.html 4.03 kB 3.66 kB -362 B
link.html gzip 1.02 kB 954 B -68 B
withRouter.html 4.03 kB 3.67 kB -362 B
withRouter.html gzip 1.01 kB 941 B -68 B
Overall change 11.6 kB 10.9 kB -612 B

Diffs

Diff for main-HASH.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[12],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
@@ -368,7 +368,7 @@ if (!window.Promise) {
 
 var data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-var version = "9.1.2-canary.3";
+var version = "9.1.2-canary.2";
 exports.version = version;
 var props = data.props,
     err = data.err,
@@ -1772,4 +1772,4 @@ exports["default"] = PageLoader;
 
 /***/ })
 
-},[["BMP1",0,1,2,3,4]]]);
\ No newline at end of file
+},[["BMP1",0,1,2,3]]]);
\ No newline at end of file
Diff for main-HASH.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {
@@ -425,7 +425,7 @@ if (!window.Promise) {
 
 const data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-const version = "9.1.2-canary.3";
+const version = "9.1.2-canary.2";
 exports.version = version;
 const {
   props,
@@ -1597,4 +1597,4 @@ exports.default = PageLoader;
 
 /***/ })
 
-},[["BMP1",0,1,2,3]]]);
\ No newline at end of file
+},[["BMP1",0,1,2]]]);
\ No newline at end of file
Diff for _app.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "B5Ud":
 /***/ (function(module, exports, __webpack_require__) {
@@ -31,14 +31,19 @@ var _asyncToGenerator2 = _interopRequireDefault(__webpack_require__("+oT+"));
 
 var _react = _interopRequireDefault(__webpack_require__("q1tI"));
 
+var _propTypes = _interopRequireDefault(__webpack_require__("17x9"));
+
 var _utils = __webpack_require__("g/15");
 
 exports.AppInitialProps = _utils.AppInitialProps;
+
+var _router = __webpack_require__("nOHt");
 /**
 * `App` component is used for initialize of pages. It allows for overwriting and full control of the `page` initialization.
 * This allows for keeping state between navigation, custom error handling, injecting additional data.
 */
 
+
 function appGetInitialProps(_x) {
   return _appGetInitialProps.apply(this, arguments);
 }
@@ -84,10 +89,17 @@ function (_react$default$Compon) {
   }
 
   _createClass(App, [{
-    key: "componentDidCatch",
-    // Kept here for backwards compatibility.
+    key: "getChildContext",
+    value: function getChildContext() {
+      return {
+        router: (0, _router.makePublicRouterInstance)(this.props.router)
+      };
+    } // Kept here for backwards compatibility.
     // When someone ended App they could call `super.componentDidCatch`.
     // @deprecated This method is no longer needed. Errors are caught at the top level
+
+  }, {
+    key: "componentDidCatch",
     value: function componentDidCatch(error, _errorInfo) {
       throw error;
     }
@@ -109,6 +121,9 @@ function (_react$default$Compon) {
 }(_react["default"].Component);
 
 exports["default"] = App;
+App.childContextTypes = {
+  router: _propTypes["default"].object
+};
 App.origGetInitialProps = appGetInitialProps;
 App.getInitialProps = appGetInitialProps;
 var warnContainer;
Diff for _error.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {
@@ -393,15 +393,6 @@ module.exports = function (NAME) {
 
 /***/ }),
 
-/***/ "9BDd":
-/***/ (function(module, exports, __webpack_require__) {
-
-__webpack_require__("GvbO");
-module.exports = __webpack_require__("WEpk").Array.isArray;
-
-
-/***/ }),
-
 /***/ "B9jh":
 /***/ (function(module, exports, __webpack_require__) {
 
@@ -475,17 +466,6 @@ exports.HeadManagerContext = React.createContext(null);
 
 /***/ }),
 
-/***/ "GvbO":
-/***/ (function(module, exports, __webpack_require__) {
-
-// 22.1.2.2 / 15.4.3.2 Array.isArray(arg)
-var $export = __webpack_require__("Y7ZC");
-
-$export($export.S, 'Array', { isArray: __webpack_require__("kAMH") });
-
-
-/***/ }),
-
 /***/ "IP1Z":
 /***/ (function(module, exports, __webpack_require__) {
 
@@ -1071,13 +1051,6 @@ module.exports = function (it, TYPE) {
 
 /***/ }),
 
-/***/ "p0XB":
-/***/ (function(module, exports, __webpack_require__) {
-
-module.exports = __webpack_require__("9BDd");
-
-/***/ }),
-
 /***/ "raTm":
 /***/ (function(module, exports, __webpack_require__) {
Diff for hooks.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
Diff for index.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
Diff for link.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
@@ -828,4 +828,4 @@ module.exports = function (original, length) {
 
 /***/ })
 
-},[["V8Sf",0,1,2,3,4]]]);
\ No newline at end of file
+},[["V8Sf",0,1,2,3]]]);
\ No newline at end of file
Diff for routerDirect.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {
@@ -40,4 +40,4 @@ routerDirect.getInitialProps = function () {
 
 /***/ })
 
-},[["LtRI",0,1,2,3,4]]]);
\ No newline at end of file
+},[["LtRI",0,1,2,3]]]);
\ No newline at end of file
Diff for withRouter.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[11],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -38,4 +38,4 @@ useWithRouter.getInitialProps = function () {
 
 /***/ })
 
-},[["eThv",0,1,2,3,4]]]);
\ No newline at end of file
+},[["eThv",0,1,2,3]]]);
\ No newline at end of file
Diff for _app.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[3],{
 
 /***/ "+oT+":
 /***/ (function(module, exports, __webpack_require__) {
@@ -64,14 +64,19 @@ var _asyncToGenerator2 = _interopRequireDefault(__webpack_require__("+oT+"));
 
 var _react = _interopRequireDefault(__webpack_require__("q1tI"));
 
+var _propTypes = _interopRequireDefault(__webpack_require__("17x9"));
+
 var _utils = __webpack_require__("g/15");
 
 exports.AppInitialProps = _utils.AppInitialProps;
+
+var _router = __webpack_require__("nOHt");
 /**
 * `App` component is used for initialize of pages. It allows for overwriting and full control of the `page` initialization.
 * This allows for keeping state between navigation, custom error handling, injecting additional data.
 */
 
+
 function appGetInitialProps(_x) {
   return _appGetInitialProps.apply(this, arguments);
 }
@@ -91,9 +96,15 @@ function _appGetInitialProps() {
 }
 
 class App extends _react.default.Component {
-  // Kept here for backwards compatibility.
+  getChildContext() {
+    return {
+      router: (0, _router.makePublicRouterInstance)(this.props.router)
+    };
+  } // Kept here for backwards compatibility.
   // When someone ended App they could call `super.componentDidCatch`.
   // @deprecated This method is no longer needed. Errors are caught at the top level
+
+
   componentDidCatch(error, _errorInfo) {
     throw error;
   }
@@ -113,6 +124,9 @@ class App extends _react.default.Component {
 }
 
 exports.default = App;
+App.childContextTypes = {
+  router: _propTypes.default.object
+};
 App.origGetInitialProps = appGetInitialProps;
 App.getInitialProps = appGetInitialProps;
 let warnContainer;
Diff for _error.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[4],{
 
 /***/ "+iuc":
 /***/ (function(module, exports, __webpack_require__) {
Diff for hooks.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[5],{
 
 /***/ "+MDD":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
Diff for index.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[6],{
 
 /***/ "RNiq":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
Diff for link.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[7],{
 
 /***/ "/h46":
 /***/ (function(module, exports, __webpack_require__) {
@@ -876,4 +876,4 @@ module.exports = function (original, length) {
 
 /***/ })
 
-},[["V8Sf",0,1,2,3]]]);
\ No newline at end of file
+},[["V8Sf",0,1,2]]]);
\ No newline at end of file
Diff for routerDirect.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[8],{
 
 /***/ "LtRI":
 /***/ (function(module, exports, __webpack_require__) {
@@ -38,4 +38,4 @@ routerDirect.getInitialProps = () => ({});
 
 /***/ })
 
-},[["LtRI",0,1,2,3]]]);
\ No newline at end of file
+},[["LtRI",0,1,2]]]);
\ No newline at end of file
Diff for withRouter.module.js 
@@ -1,4 +1,4 @@
-(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[10],{
+(window["webpackJsonp"] = window["webpackJsonp"] || []).push([[9],{
 
 /***/ "0Hlz":
 /***/ (function(module, __webpack_exports__, __webpack_require__) {
@@ -36,4 +36,4 @@ useWithRouter.getInitialProps = () => ({});
 
 /***/ })
 
-},[["eThv",0,1,2,3]]]);
\ No newline at end of file
+},[["eThv",0,1,2]]]);
\ No newline at end of file
Diff for _buildManifest.js 
@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.2b1d81032488778ae633.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = {};self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
Diff for _buildManifest.module.js 
@@ -1 +1 @@
-self.__BUILD_MANIFEST = (function(a){return {"/link":[a],"/routerDirect":[a],"/withRouter":[a]}}("static\u002Fchunks\u002F16b1a72255206b7853bf6603dc58ec83de39b142.9582d4f0f85e31c586e6.module.js"));self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
+self.__BUILD_MANIFEST = {};self.__BUILD_MANIFEST_CB && self.__BUILD_MANIFEST_CB()
\ No newline at end of file
Diff for index.html 
@@ -12,11 +12,13 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-896efb5d487f46655d1b.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        as="script" crossorigin="anonymous" />
+        <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -41,19 +43,19 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-f593c3c225e1a7b43ea3.js"
+        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-896efb5d487f46655d1b.module.js"
+        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.5f7e28a32dd2b9e5a61c.js"
+        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.ee7b6e94e0f57c3271e6.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.1349e44e6a93fd5f521b.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>
Diff for link.html 
@@ -14,11 +14,11 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.9582d4f0f85e31c586e6.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-896efb5d487f46655d1b.module.js"
+        <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -50,19 +50,15 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.5f7e28a32dd2b9e5a61c.js"
+        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.ee7b6e94e0f57c3271e6.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.1349e44e6a93fd5f521b.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.2b1d81032488778ae633.js"
+        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.9582d4f0f85e31c586e6.module.js"
-        async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-f593c3c225e1a7b43ea3.js"
-        async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-896efb5d487f46655d1b.module.js"
+        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>
Diff for withRouter.html 
@@ -14,11 +14,11 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.9582d4f0f85e31c586e6.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-896efb5d487f46655d1b.module.js"
+        <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
     </head>
     
@@ -48,19 +48,15 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.5f7e28a32dd2b9e5a61c.js"
+        <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.ee7b6e94e0f57c3271e6.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.1349e44e6a93fd5f521b.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5a9c6f1d58234f924f0a.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.2b1d81032488778ae633.js"
+        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/16b1a72255206b7853bf6603dc58ec83de39b142.9582d4f0f85e31c586e6.module.js"
-        async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-f593c3c225e1a7b43ea3.js"
-        async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-896efb5d487f46655d1b.module.js"
+        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
zeit/next.js canary iliran11/next.js master Change
buildDuration 15.8s 14.5s -1.3s
nodeModulesSize 48.5 MB 48.5 MB -2.81 kB
Client Bundles (main, webpack, commons) Overall decrease ✓
zeit/next.js canary iliran11/next.js master Change
main-HASH.js 18.9 kB 18.9 kB -2 B
main-HASH.js gzip 6.79 kB 6.79 kB -2 B
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..2641f57f9.js 14.9 kB N/A N/A
16b1a7225520..57f9.js gzip 5.38 kB N/A N/A
4952ddcd88e7..0fb1924cf.js 21.7 kB N/A N/A
4952ddcd88e7..24cf.js gzip 7.77 kB N/A N/A
de003c3a9d30..aab6ec1a2.js 28.6 kB N/A N/A
de003c3a9d30..c1a2.js gzip 10.8 kB N/A N/A
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
4952ddcd88e7..9dda6167a.js N/A 21.9 kB N/A
4952ddcd88e7..167a.js gzip N/A 7.81 kB N/A
de003c3a9d30..3a0560775.js N/A 43.2 kB N/A
de003c3a9d30..0775.js gzip N/A 15.5 kB N/A
Overall change 211 kB 211 kB -2 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
zeit/next.js canary iliran11/next.js master Change
main-HASH.module.js 17.2 kB 17.2 kB -2 B
main-HASH.module.js gzip 6.52 kB 6.52 kB -2 B
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..3e.module.js 10.8 kB N/A N/A
16b1a7225520..dule.js gzip 4.05 kB N/A N/A
de003c3a9d30..e6.module.js 34.8 kB N/A N/A
de003c3a9d30..dule.js gzip 12.9 kB N/A N/A
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
de003c3a9d30..72.module.js N/A 45.6 kB N/A
de003c3a9d30..dule.js gzip N/A 16.5 kB N/A
Overall change 190 kB 190 kB -2 B
Client Pages Overall decrease ✓
zeit/next.js canary iliran11/next.js master Change
_app.js 1.63 kB 1.81 kB ⚠️ +184 B
_app.js gzip 786 B 873 B ⚠️ +87 B
_error.js 12.2 kB 12 kB -183 B
_error.js gzip 4.78 kB 4.73 kB -46 B
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB -1 B
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB -2 B
link.js gzip 3.5 kB 3.5 kB -2 B
routerDirect.js 411 B 408 B -3 B
routerDirect.js gzip 283 B 281 B -2 B
withRouter.js 421 B 419 B -2 B
withRouter.js gzip 282 B 280 B -2 B
Overall change 35.9 kB 35.8 kB -6 B
Client Pages Modern Overall increase ⚠️
zeit/next.js canary iliran11/next.js master Change
_app.module.js 1.54 kB 1.7 kB ⚠️ +160 B
_app.module.js gzip 754 B 832 B ⚠️ +78 B
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 794 B 793 B -1 B
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB -2 B
link.module.js gzip 3.68 kB 3.68 kB -1 B
routerDirect.module.js 396 B 394 B -2 B
routerDirect..dule.js gzip 283 B 281 B -2 B
withRouter.module.js 407 B 404 B -3 B
withRouter.m..dule.js gzip 281 B 278 B -3 B
Overall change 35.9 kB 36.1 kB ⚠️ +153 B
Client Build Manifests Overall decrease ✓
zeit/next.js canary iliran11/next.js master Change
_buildManifest.js 244 B 81 B -163 B
_buildManifest.js gzip 199 B 61 B -138 B
_buildManifest.module.js 251 B 81 B -170 B
_buildManife..dule.js gzip 209 B 61 B -148 B
Overall change 495 B 162 B -333 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary iliran11/next.js master Change
_error.js 230 kB 254 kB ⚠️ +23.9 kB
_error.js gzip 61.5 kB 68.1 kB ⚠️ +6.54 kB
hooks.html 3.64 kB 3.75 kB ⚠️ +112 B
hooks.html gzip 974 B 979 B ⚠️ +5 B
index.js 231 kB 255 kB ⚠️ +24 kB
index.js gzip 61.8 kB 68.4 kB ⚠️ +6.62 kB
link.js 263 kB 262 kB -700 B
link.js gzip 70.6 kB 70.4 kB -164 B
routerDirect.js 256 kB 255 kB -700 B
routerDirect.js gzip 68.6 kB 68.4 kB -168 B
withRouter.js 256 kB 255 kB -700 B
withRouter.js gzip 68.7 kB 68.5 kB -183 B
Overall change 1.24 MB 1.29 MB ⚠️ +45.9 kB

Commit: 2d837f4

@ijjk
Copy link
Member

ijjk commented Oct 16, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary iliran11/next.js master Change
buildDuration 15.1s 15.4s ⚠️ +371ms
nodeModulesSize 48.5 MB 48.5 MB ⚠️ +372 B
Client Bundles (main, webpack, commons)
zeit/next.js canary iliran11/next.js master Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..2641f57f9.js 14.9 kB 14.9 kB ✓
16b1a7225520..57f9.js gzip 5.38 kB 5.38 kB ✓
4952ddcd88e7..0fb1924cf.js 21.7 kB 21.7 kB ✓
4952ddcd88e7..24cf.js gzip 7.77 kB 7.77 kB ✓
de003c3a9d30..aab6ec1a2.js 28.6 kB 28.6 kB ✓
de003c3a9d30..c1a2.js gzip 10.8 kB 10.8 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary iliran11/next.js master Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..3e.module.js 10.8 kB 10.8 kB ✓
16b1a7225520..dule.js gzip 4.05 kB 4.05 kB ✓
de003c3a9d30..e6.module.js 34.8 kB 34.8 kB ✓
de003c3a9d30..dule.js gzip 12.9 kB 12.9 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary iliran11/next.js master Change
_app.js 1.63 kB 1.63 kB ✓
_app.js gzip 786 B 786 B ✓
_error.js 12.2 kB 12.2 kB ✓
_error.js gzip 4.78 kB 4.78 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 411 B 411 B ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js 421 B 421 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 35.9 kB 35.9 kB ✓
Client Pages Modern
zeit/next.js canary iliran11/next.js master Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 754 B 754 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 794 B 794 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 396 B 396 B ✓
routerDirect..dule.js gzip 283 B 283 B ✓
withRouter.module.js 407 B 407 B ✓
withRouter.m..dule.js gzip 281 B 281 B ✓
Overall change 35.9 kB 35.9 kB ✓
Client Build Manifests
zeit/next.js canary iliran11/next.js master Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 199 B 199 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 209 B 209 B ✓
Overall change 495 B 495 B ✓
Rendered Page Sizes
zeit/next.js canary iliran11/next.js master Change
index.html 3.5 kB 3.5 kB ✓
index.html gzip 944 B 944 B ✓
link.html 4.03 kB 4.03 kB ✓
link.html gzip 1.02 kB 1.02 kB ✓
withRouter.html 4.03 kB 4.03 kB ✓
withRouter.html gzip 1.01 kB 1.01 kB ✓
Overall change 11.6 kB 11.6 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary iliran11/next.js master Change
buildDuration 15.6s 15.8s ⚠️ +201ms
nodeModulesSize 48.5 MB 48.5 MB ⚠️ +372 B
Client Bundles (main, webpack, commons)
zeit/next.js canary iliran11/next.js master Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..2641f57f9.js 14.9 kB 14.9 kB ✓
16b1a7225520..57f9.js gzip 5.38 kB 5.38 kB ✓
4952ddcd88e7..0fb1924cf.js 21.7 kB 21.7 kB ✓
4952ddcd88e7..24cf.js gzip 7.77 kB 7.77 kB ✓
de003c3a9d30..aab6ec1a2.js 28.6 kB 28.6 kB ✓
de003c3a9d30..c1a2.js gzip 10.8 kB 10.8 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary iliran11/next.js master Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..3e.module.js 10.8 kB 10.8 kB ✓
16b1a7225520..dule.js gzip 4.05 kB 4.05 kB ✓
de003c3a9d30..e6.module.js 34.8 kB 34.8 kB ✓
de003c3a9d30..dule.js gzip 12.9 kB 12.9 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary iliran11/next.js master Change
_app.js 1.63 kB 1.63 kB ✓
_app.js gzip 786 B 786 B ✓
_error.js 12.2 kB 12.2 kB ✓
_error.js gzip 4.78 kB 4.78 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 411 B 411 B ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js 421 B 421 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 35.9 kB 35.9 kB ✓
Client Pages Modern
zeit/next.js canary iliran11/next.js master Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 754 B 754 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 794 B 794 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 396 B 396 B ✓
routerDirect..dule.js gzip 283 B 283 B ✓
withRouter.module.js 407 B 407 B ✓
withRouter.m..dule.js gzip 281 B 281 B ✓
Overall change 35.9 kB 35.9 kB ✓
Client Build Manifests
zeit/next.js canary iliran11/next.js master Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 199 B 199 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 209 B 209 B ✓
Overall change 495 B 495 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary iliran11/next.js master Change
_error.js 230 kB 231 kB ⚠️ +228 B
_error.js gzip 61.5 kB 61.5 kB ⚠️ +29 B
hooks.html 3.64 kB 3.64 kB ✓
hooks.html gzip 974 B 974 B ✓
index.js 231 kB 231 kB ⚠️ +228 B
index.js gzip 61.8 kB 61.8 kB ⚠️ +28 B
link.js 263 kB 263 kB ⚠️ +228 B
link.js gzip 70.6 kB 70.6 kB ⚠️ +28 B
routerDirect.js 256 kB 256 kB ⚠️ +228 B
routerDirect.js gzip 68.6 kB 68.6 kB ⚠️ +29 B
withRouter.js 256 kB 256 kB ⚠️ +228 B
withRouter.js gzip 68.7 kB 68.7 kB ⚠️ +30 B
Overall change 1.24 MB 1.24 MB ⚠️ +1.14 kB

Commit: 0b457cb

@ijjk
Copy link
Member

ijjk commented Oct 16, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary iliran11/next.js master Change
buildDuration 15.2s 15.2s ⚠️ +2ms
nodeModulesSize 48.5 MB 48.5 MB ⚠️ +372 B
Client Bundles (main, webpack, commons)
zeit/next.js canary iliran11/next.js master Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..2641f57f9.js 14.9 kB 14.9 kB ✓
16b1a7225520..57f9.js gzip 5.38 kB 5.38 kB ✓
4952ddcd88e7..0fb1924cf.js 21.7 kB 21.7 kB ✓
4952ddcd88e7..24cf.js gzip 7.77 kB 7.77 kB ✓
de003c3a9d30..aab6ec1a2.js 28.6 kB 28.6 kB ✓
de003c3a9d30..c1a2.js gzip 10.8 kB 10.8 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary iliran11/next.js master Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..3e.module.js 10.8 kB 10.8 kB ✓
16b1a7225520..dule.js gzip 4.05 kB 4.05 kB ✓
de003c3a9d30..e6.module.js 34.8 kB 34.8 kB ✓
de003c3a9d30..dule.js gzip 12.9 kB 12.9 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary iliran11/next.js master Change
_app.js 1.63 kB 1.63 kB ✓
_app.js gzip 786 B 786 B ✓
_error.js 12.2 kB 12.2 kB ✓
_error.js gzip 4.78 kB 4.78 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 411 B 411 B ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js 421 B 421 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 35.9 kB 35.9 kB ✓
Client Pages Modern
zeit/next.js canary iliran11/next.js master Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 754 B 754 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 794 B 794 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 396 B 396 B ✓
routerDirect..dule.js gzip 283 B 283 B ✓
withRouter.module.js 407 B 407 B ✓
withRouter.m..dule.js gzip 281 B 281 B ✓
Overall change 35.9 kB 35.9 kB ✓
Client Build Manifests
zeit/next.js canary iliran11/next.js master Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 199 B 199 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 209 B 209 B ✓
Overall change 495 B 495 B ✓
Rendered Page Sizes
zeit/next.js canary iliran11/next.js master Change
index.html 3.5 kB 3.5 kB ✓
index.html gzip 944 B 944 B ✓
link.html 4.03 kB 4.03 kB ✓
link.html gzip 1.02 kB 1.02 kB ✓
withRouter.html 4.03 kB 4.03 kB ✓
withRouter.html gzip 1.01 kB 1.01 kB ✓
Overall change 11.6 kB 11.6 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary iliran11/next.js master Change
buildDuration 15.2s 15.6s ⚠️ +377ms
nodeModulesSize 48.5 MB 48.5 MB ⚠️ +372 B
Client Bundles (main, webpack, commons)
zeit/next.js canary iliran11/next.js master Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..2641f57f9.js 14.9 kB 14.9 kB ✓
16b1a7225520..57f9.js gzip 5.38 kB 5.38 kB ✓
4952ddcd88e7..0fb1924cf.js 21.7 kB 21.7 kB ✓
4952ddcd88e7..24cf.js gzip 7.77 kB 7.77 kB ✓
de003c3a9d30..aab6ec1a2.js 28.6 kB 28.6 kB ✓
de003c3a9d30..c1a2.js gzip 10.8 kB 10.8 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary iliran11/next.js master Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..3e.module.js 10.8 kB 10.8 kB ✓
16b1a7225520..dule.js gzip 4.05 kB 4.05 kB ✓
de003c3a9d30..e6.module.js 34.8 kB 34.8 kB ✓
de003c3a9d30..dule.js gzip 12.9 kB 12.9 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary iliran11/next.js master Change
_app.js 1.63 kB 1.63 kB ✓
_app.js gzip 786 B 786 B ✓
_error.js 12.2 kB 12.2 kB ✓
_error.js gzip 4.78 kB 4.78 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 411 B 411 B ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js 421 B 421 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 35.9 kB 35.9 kB ✓
Client Pages Modern
zeit/next.js canary iliran11/next.js master Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 754 B 754 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 794 B 794 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 396 B 396 B ✓
routerDirect..dule.js gzip 283 B 283 B ✓
withRouter.module.js 407 B 407 B ✓
withRouter.m..dule.js gzip 281 B 281 B ✓
Overall change 35.9 kB 35.9 kB ✓
Client Build Manifests
zeit/next.js canary iliran11/next.js master Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 199 B 199 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 209 B 209 B ✓
Overall change 495 B 495 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary iliran11/next.js master Change
_error.js 230 kB 231 kB ⚠️ +228 B
_error.js gzip 61.5 kB 61.5 kB ⚠️ +29 B
hooks.html 3.64 kB 3.64 kB ✓
hooks.html gzip 974 B 974 B ✓
index.js 231 kB 231 kB ⚠️ +228 B
index.js gzip 61.8 kB 61.8 kB ⚠️ +28 B
link.js 263 kB 263 kB ⚠️ +228 B
link.js gzip 70.6 kB 70.6 kB ⚠️ +28 B
routerDirect.js 256 kB 256 kB ⚠️ +228 B
routerDirect.js gzip 68.6 kB 68.6 kB ⚠️ +29 B
withRouter.js 256 kB 256 kB ⚠️ +228 B
withRouter.js gzip 68.7 kB 68.7 kB ⚠️ +30 B
Overall change 1.24 MB 1.24 MB ⚠️ +1.14 kB

Commit: 17de15c

@c0b41
Copy link
Contributor

c0b41 commented Oct 16, 2019

@iliran11 thanks for the pr, i can confirm this bug.

@ijjk
Copy link
Member

ijjk commented Oct 16, 2019

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary iliran11/next.js master Change
buildDuration 15.6s 15.3s -279ms
nodeModulesSize 48.5 MB 48.5 MB ⚠️ +372 B
Client Bundles (main, webpack, commons)
zeit/next.js canary iliran11/next.js master Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..2641f57f9.js 14.9 kB 14.9 kB ✓
16b1a7225520..57f9.js gzip 5.38 kB 5.38 kB ✓
4952ddcd88e7..0fb1924cf.js 21.7 kB 21.7 kB ✓
4952ddcd88e7..24cf.js gzip 7.77 kB 7.77 kB ✓
de003c3a9d30..aab6ec1a2.js 28.6 kB 28.6 kB ✓
de003c3a9d30..c1a2.js gzip 10.8 kB 10.8 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary iliran11/next.js master Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..3e.module.js 10.8 kB 10.8 kB ✓
16b1a7225520..dule.js gzip 4.05 kB 4.05 kB ✓
de003c3a9d30..e6.module.js 34.8 kB 34.8 kB ✓
de003c3a9d30..dule.js gzip 12.9 kB 12.9 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary iliran11/next.js master Change
_app.js 1.63 kB 1.63 kB ✓
_app.js gzip 786 B 786 B ✓
_error.js 12.2 kB 12.2 kB ✓
_error.js gzip 4.78 kB 4.78 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 411 B 411 B ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js 421 B 421 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 35.9 kB 35.9 kB ✓
Client Pages Modern
zeit/next.js canary iliran11/next.js master Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 754 B 754 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 794 B 794 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 396 B 396 B ✓
routerDirect..dule.js gzip 283 B 283 B ✓
withRouter.module.js 407 B 407 B ✓
withRouter.m..dule.js gzip 281 B 281 B ✓
Overall change 35.9 kB 35.9 kB ✓
Client Build Manifests
zeit/next.js canary iliran11/next.js master Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 199 B 199 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 209 B 209 B ✓
Overall change 495 B 495 B ✓
Rendered Page Sizes
zeit/next.js canary iliran11/next.js master Change
index.html 3.5 kB 3.5 kB ✓
index.html gzip 943 B 943 B ✓
link.html 4.03 kB 4.03 kB ✓
link.html gzip 1.02 kB 1.02 kB ✓
withRouter.html 4.03 kB 4.03 kB ✓
withRouter.html gzip 1.01 kB 1.01 kB ✓
Overall change 11.6 kB 11.6 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary iliran11/next.js master Change
buildDuration 16.2s 15.6s -555ms
nodeModulesSize 48.5 MB 48.5 MB ⚠️ +372 B
Client Bundles (main, webpack, commons)
zeit/next.js canary iliran11/next.js master Change
main-HASH.js 18.9 kB 18.9 kB ✓
main-HASH.js gzip 6.79 kB 6.79 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..2641f57f9.js 14.9 kB 14.9 kB ✓
16b1a7225520..57f9.js gzip 5.38 kB 5.38 kB ✓
4952ddcd88e7..0fb1924cf.js 21.7 kB 21.7 kB ✓
4952ddcd88e7..24cf.js gzip 7.77 kB 7.77 kB ✓
de003c3a9d30..aab6ec1a2.js 28.6 kB 28.6 kB ✓
de003c3a9d30..c1a2.js gzip 10.8 kB 10.8 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 211 kB 211 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary iliran11/next.js master Change
main-HASH.module.js 17.2 kB 17.2 kB ✓
main-HASH.module.js gzip 6.52 kB 6.52 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..3e.module.js 10.8 kB 10.8 kB ✓
16b1a7225520..dule.js gzip 4.05 kB 4.05 kB ✓
de003c3a9d30..e6.module.js 34.8 kB 34.8 kB ✓
de003c3a9d30..dule.js gzip 12.9 kB 12.9 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 190 kB 190 kB ✓
Client Pages
zeit/next.js canary iliran11/next.js master Change
_app.js 1.63 kB 1.63 kB ✓
_app.js gzip 786 B 786 B ✓
_error.js 12.2 kB 12.2 kB ✓
_error.js gzip 4.78 kB 4.78 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.14 kB 8.14 kB ✓
link.js gzip 3.5 kB 3.5 kB ✓
routerDirect.js 411 B 411 B ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js 421 B 421 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 35.9 kB 35.9 kB ✓
Client Pages Modern
zeit/next.js canary iliran11/next.js master Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 754 B 754 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 794 B 794 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.53 kB 8.53 kB ✓
link.module.js gzip 3.68 kB 3.68 kB ✓
routerDirect.module.js 396 B 396 B ✓
routerDirect..dule.js gzip 283 B 283 B ✓
withRouter.module.js 407 B 407 B ✓
withRouter.m..dule.js gzip 281 B 281 B ✓
Overall change 35.9 kB 35.9 kB ✓
Client Build Manifests
zeit/next.js canary iliran11/next.js master Change
_buildManifest.js 244 B 244 B ✓
_buildManifest.js gzip 199 B 199 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 209 B 209 B ✓
Overall change 495 B 495 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary iliran11/next.js master Change
_error.js 230 kB 231 kB ⚠️ +228 B
_error.js gzip 61.5 kB 61.5 kB ⚠️ +30 B
hooks.html 3.64 kB 3.64 kB ✓
hooks.html gzip 973 B 973 B ✓
index.js 231 kB 231 kB ⚠️ +228 B
index.js gzip 61.8 kB 61.8 kB ⚠️ +28 B
link.js 263 kB 263 kB ⚠️ +228 B
link.js gzip 70.6 kB 70.6 kB ⚠️ +28 B
routerDirect.js 256 kB 256 kB ⚠️ +228 B
routerDirect.js gzip 68.6 kB 68.6 kB ⚠️ +29 B
withRouter.js 256 kB 256 kB ⚠️ +228 B
withRouter.js gzip 68.7 kB 68.7 kB ⚠️ +30 B
Overall change 1.24 MB 1.24 MB ⚠️ +1.14 kB

Commit: 0b5a513

@c0b41
Copy link
Contributor

c0b41 commented Oct 18, 2019

@Timer can we get this pull request?

@Timer Timer added this to the 9.1.2 milestone Oct 18, 2019
ijjk
ijjk approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I updated it to dedupe the looping since we're doing it in AMP mode and non-AMP mode now so we can share a loop

@ijjk ijjk merged commit b7efb3f into vercel:canary Oct 18, 2019
@iliran11 iliran11 deleted the master branch October 18, 2019 18:20
This was referenced Nov 12, 2019
Merged
Open
Open
Open
This was referenced Nov 19, 2019
Merged
Open
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@iliran11 @ijjk @c0b41 @Timer