Temporary: SPR: Use Group Index Mapping #9089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is a temporary addition that uses the `x-now-route-params` header in serverless. This header returns the regex groups with indexes, not their named variants. As a result, we must use the getRouteMatcher utility to reverse this into Next.js' expected names. Since this got complex, I've added a test for it. We should probably remove this behavior sooner than later.
ijjk
approved these changes
Oct 15, 2019
This was referenced Nov 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a temporary addition that uses the
x-now-route-paramsheader in serverless.This header returns the regex groups with indexes, not their named variants.
As a result, we must use the
getRouteMatcherutility to reverse this into Next.js' expected names.Since this got complex, I've added a test for it. We should probably remove this behavior sooner than later.