[using-inferno] Update inferno to v7.3, fix missing React.createContext function #9038

rafaelalmeidatk · 2019-10-11T06:32:25Z

I utilized the create-react-context lib to polyfill the React.createContext function that is not covered by inferno-compat.

Closes #9021

ijjk · 2019-10-11T06:37:20Z

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
buildDuration	14.8s	14.9s	⚠️ +174ms
nodeModulesSize	48.4 MB	48.4 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..1c22faff4.js	43.2 kB	43.2 kB	✓
de003c3a9d30..aff4.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..76.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	948 B	948 B	✓
link.html	3.66 kB	3.66 kB	✓
link.html gzip	955 B	955 B	✓
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	943 B	943 B	✓
Overall change	10.9 kB	10.9 kB	✓

Serverless Mode

General

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
buildDuration	15.2s	15.4s	⚠️ +274ms
nodeModulesSize	48.4 MB	48.4 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..1c22faff4.js	43.2 kB	43.2 kB	✓
de003c3a9d30..aff4.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..76.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_error.js	254 kB	254 kB	✓
_error.js gzip	68 kB	68 kB	✓
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	981 B	981 B	✓
index.js	254 kB	254 kB	✓
index.js gzip	68.3 kB	68.3 kB	✓
link.js	262 kB	262 kB	✓
link.js gzip	70.3 kB	70.3 kB	✓
routerDirect.js	255 kB	255 kB	✓
routerDirect.js gzip	68.4 kB	68.4 kB	✓
withRouter.js	255 kB	255 kB	✓
withRouter.js gzip	68.4 kB	68.4 kB	✓
Overall change	1.28 MB	1.28 MB	✓

Commit: cd9bdca

lfades

I get this after running yarn build and yarn start

In another note: Why is a custom server required?

rafaelalmeidatk · 2019-10-12T03:41:07Z

@lfades ops sorry, I forgot to change the aliases on next.config.js as well.

Why is a custom server required?

Good question, I asked myself that too. Looks like it is just to use module-alias, but this example is 3 years old so maybe it isn't necessary anymore. The config on next.config.js already aliases the modules, what do you think?

ijjk · 2019-10-12T03:43:55Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
buildDuration	15.1s	15.2s	⚠️ +84ms
nodeModulesSize	48.4 MB	48.4 MB	-349 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..3a0560775.js	43.2 kB	N/A	N/A
de003c3a9d30..0775.js gzip	15.5 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
de003c3a9d30..1c22faff4.js	N/A	43.2 kB	N/A
de003c3a9d30..aff4.js gzip	N/A	15.5 kB	N/A
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..97.module.js	45.6 kB	N/A	N/A
de003c3a9d30..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
de003c3a9d30..76.module.js	N/A	45.6 kB	N/A
de003c3a9d30..dule.js gzip	N/A	16.5 kB	N/A
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	947 B	948 B	⚠️ +1 B
link.html	3.66 kB	3.66 kB	✓
link.html gzip	955 B	955 B	✓
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	942 B	943 B	⚠️ +1 B
Overall change	10.9 kB	10.9 kB	✓

Diffs

Diff for main-HASH.js

@@ -368,7 +368,7 @@ if (!window.Promise) {
 
 var data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-var version = "9.1.2-canary.2";
+var version = "9.1.2-canary.1";
 exports.version = version;
 var props = data.props,
     err = data.err,

Diff for main-HASH.module.js

@@ -425,7 +425,7 @@ if (!window.Promise) {
 
 const data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-const version = "9.1.2-canary.2";
+const version = "9.1.2-canary.1";
 exports.version = version;
 const {
   props,

Diff for index.html

@@ -12,11 +12,11 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0141ac1128973a22b076.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.10c25de0afdcbc0f8fd3.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -43,9 +43,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
+        <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <script src="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -53,9 +53,9 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7d0809752ed3b84b9be0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0141ac1128973a22b076.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.10c25de0afdcbc0f8fd3.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for link.html

@@ -14,9 +14,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0141ac1128973a22b076.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.10c25de0afdcbc0f8fd3.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -52,13 +52,13 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7d0809752ed3b84b9be0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0141ac1128973a22b076.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.10c25de0afdcbc0f8fd3.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
+        <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <script src="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for withRouter.html

@@ -14,9 +14,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0141ac1128973a22b076.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.10c25de0afdcbc0f8fd3.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -50,13 +50,13 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7d0809752ed3b84b9be0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0141ac1128973a22b076.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.10c25de0afdcbc0f8fd3.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
+        <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <script src="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
buildDuration	15.3s	15.1s	-152ms
nodeModulesSize	48.4 MB	48.4 MB	-349 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..3a0560775.js	43.2 kB	N/A	N/A
de003c3a9d30..0775.js gzip	15.5 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
de003c3a9d30..1c22faff4.js	N/A	43.2 kB	N/A
de003c3a9d30..aff4.js gzip	N/A	15.5 kB	N/A
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..97.module.js	45.6 kB	N/A	N/A
de003c3a9d30..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
de003c3a9d30..76.module.js	N/A	45.6 kB	N/A
de003c3a9d30..dule.js gzip	N/A	16.5 kB	N/A
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_error.js	254 kB	254 kB	-78 B
_error.js gzip	68 kB	68 kB	-17 B
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	980 B	981 B	⚠️ +1 B
index.js	254 kB	254 kB	-78 B
index.js gzip	68.3 kB	68.3 kB	-21 B
link.js	262 kB	262 kB	-78 B
link.js gzip	70.4 kB	70.3 kB	-20 B
routerDirect.js	255 kB	255 kB	-78 B
routerDirect.js gzip	68.4 kB	68.4 kB	-22 B
withRouter.js	255 kB	255 kB	-78 B
withRouter.js gzip	68.5 kB	68.4 kB	-21 B
Overall change	1.28 MB	1.28 MB	-390 B

Commit: fb74ebf

ijjk · 2019-10-12T18:57:04Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
buildDuration	15.5s	15.9s	⚠️ +362ms
nodeModulesSize	48.4 MB	48.4 MB	-349 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..3a0560775.js	43.2 kB	N/A	N/A
de003c3a9d30..0775.js gzip	15.5 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
de003c3a9d30..1c22faff4.js	N/A	43.2 kB	N/A
de003c3a9d30..aff4.js gzip	N/A	15.5 kB	N/A
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..97.module.js	45.6 kB	N/A	N/A
de003c3a9d30..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
de003c3a9d30..76.module.js	N/A	45.6 kB	N/A
de003c3a9d30..dule.js gzip	N/A	16.5 kB	N/A
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	947 B	948 B	⚠️ +1 B
link.html	3.66 kB	3.66 kB	✓
link.html gzip	955 B	955 B	✓
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	942 B	943 B	⚠️ +1 B
Overall change	10.9 kB	10.9 kB	✓

Diffs

Diff for main-HASH.js

@@ -368,7 +368,7 @@ if (!window.Promise) {
 
 var data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-var version = "9.1.2-canary.2";
+var version = "9.1.2-canary.1";
 exports.version = version;
 var props = data.props,
     err = data.err,

Diff for main-HASH.module.js

@@ -425,7 +425,7 @@ if (!window.Promise) {
 
 const data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-const version = "9.1.2-canary.2";
+const version = "9.1.2-canary.1";
 exports.version = version;
 const {
   props,

Diff for index.html

@@ -12,11 +12,11 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0141ac1128973a22b076.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.10c25de0afdcbc0f8fd3.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -43,9 +43,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
+        <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <script src="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -53,9 +53,9 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7d0809752ed3b84b9be0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0141ac1128973a22b076.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.10c25de0afdcbc0f8fd3.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for link.html

@@ -14,9 +14,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0141ac1128973a22b076.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.10c25de0afdcbc0f8fd3.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -52,13 +52,13 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7d0809752ed3b84b9be0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0141ac1128973a22b076.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.10c25de0afdcbc0f8fd3.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
+        <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <script src="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for withRouter.html

@@ -14,9 +14,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0141ac1128973a22b076.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.10c25de0afdcbc0f8fd3.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -50,13 +50,13 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.155621535702fe040780.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7d0809752ed3b84b9be0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0141ac1128973a22b076.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.10c25de0afdcbc0f8fd3.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
+        <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <script src="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
buildDuration	15.4s	14.9s	-570ms
nodeModulesSize	48.4 MB	48.4 MB	-349 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..3a0560775.js	43.2 kB	N/A	N/A
de003c3a9d30..0775.js gzip	15.5 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
de003c3a9d30..1c22faff4.js	N/A	43.2 kB	N/A
de003c3a9d30..aff4.js gzip	N/A	15.5 kB	N/A
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..97.module.js	45.6 kB	N/A	N/A
de003c3a9d30..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
de003c3a9d30..76.module.js	N/A	45.6 kB	N/A
de003c3a9d30..dule.js gzip	N/A	16.5 kB	N/A
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_error.js	254 kB	254 kB	-78 B
_error.js gzip	68 kB	68 kB	-17 B
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	980 B	981 B	⚠️ +1 B
index.js	254 kB	254 kB	-78 B
index.js gzip	68.3 kB	68.3 kB	-21 B
link.js	262 kB	262 kB	-78 B
link.js gzip	70.4 kB	70.3 kB	-20 B
routerDirect.js	255 kB	255 kB	-78 B
routerDirect.js gzip	68.4 kB	68.4 kB	-22 B
withRouter.js	255 kB	255 kB	-78 B
withRouter.js gzip	68.5 kB	68.4 kB	-21 B
Overall change	1.28 MB	1.28 MB	-390 B

Commit: ece656f

rafaelalmeidatk · 2019-10-12T20:14:17Z

Ok, now I get it. If I don't use the custom server with module-alias, Next.js will try to use react instead of the aliased version. This doesn't happen in this example because we are not using Inferno during dev, but I think react should not even be in the dependencies. (in the Preact example, it doesn't have react in the dependencies so it is broken)

Problem is: I don't know if there is a way to alias react before next build runs, so if I remove react and react-dom from the dependencies, Next will fail to build the project.

ijjk · 2019-10-15T05:26:15Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
buildDuration	15s	16.8s	⚠️ +1.7s
nodeModulesSize	48.5 MB	48.5 MB	-1.33 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..9dda6167a.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..167a.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..3a0560775.js	43.2 kB	N/A	N/A
de003c3a9d30..0775.js gzip	15.5 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
de003c3a9d30..1c22faff4.js	N/A	43.2 kB	N/A
de003c3a9d30..aff4.js gzip	N/A	15.5 kB	N/A
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..72.module.js	45.6 kB	N/A	N/A
de003c3a9d30..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
de003c3a9d30..c1.module.js	N/A	45.6 kB	N/A
de003c3a9d30..dule.js gzip	N/A	16.5 kB	N/A
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	946 B	945 B	-1 B
link.html	3.66 kB	3.66 kB	✓
link.html gzip	954 B	953 B	-1 B
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	941 B	940 B	-1 B
Overall change	10.9 kB	10.9 kB	✓

Diffs

Diff for main-HASH.js

@@ -368,7 +368,7 @@ if (!window.Promise) {
 
 var data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-var version = "9.1.2-canary.2";
+var version = "9.1.2-canary.1";
 exports.version = version;
 var props = data.props,
     err = data.err,

Diff for main-HASH.module.js

@@ -425,7 +425,7 @@ if (!window.Promise) {
 
 const data = JSON.parse(document.getElementById('__NEXT_DATA__').textContent);
 window.__NEXT_DATA__ = data;
-const version = "9.1.2-canary.2";
+const version = "9.1.2-canary.1";
 exports.version = version;
 const {
   props,

Diff for index.html

@@ -12,11 +12,11 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.3309b0e617ff9533d020.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -43,9 +43,9 @@
         async="" crossorigin="anonymous" nomodule=""></script>
         <script src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
+        <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <script src="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/framework.cdb73e402d876d4ac87f.js"
         async="" crossorigin="anonymous" nomodule=""></script>
@@ -53,9 +53,9 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.ee7b6e94e0f57c3271e6.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7d0809752ed3b84b9be0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.3309b0e617ff9533d020.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for link.html

@@ -14,9 +14,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.3309b0e617ff9533d020.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -52,13 +52,13 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.ee7b6e94e0f57c3271e6.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7d0809752ed3b84b9be0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.3309b0e617ff9533d020.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
+        <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <script src="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Diff for withRouter.html

@@ -14,9 +14,9 @@
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/chunks/framework.cdb73e402d876d4ac87f.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <link rel="preload" href="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.3309b0e617ff9533d020.module.js"
         as="script" crossorigin="anonymous" />
-        <link rel="preload" href="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <link rel="preload" href="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         as="script" crossorigin="anonymous" />
         <link rel="preload" href="/_next/static/BUILD_ID/_buildManifest.module.js"
         as="script" crossorigin="anonymous" />
@@ -50,13 +50,13 @@
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/chunks/4952ddcd88e7185e66c9cf40e2d848b7e27f1574.ee7b6e94e0f57c3271e6.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.0846ed0c3213c3fa4852.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.7d0809752ed3b84b9be0.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.5b7040577e237566bd64.module.js"
+        <script src="/_next/static/chunks/de003c3a9d308750aa009870a5926f9b18ab31f4.3309b0e617ff9533d020.module.js"
         async="" crossorigin="anonymous" type="module"></script>
-        <script src="/_next/static/runtime/main-79e358a90975f82b2592.js"
+        <script src="/_next/static/runtime/main-2a0662a64c4de1a8ddad.js"
         async="" crossorigin="anonymous" nomodule=""></script>
-        <script src="/_next/static/runtime/main-20689a9159cf8f62c223.module.js"
+        <script src="/_next/static/runtime/main-88f74919d3b02083b7e6.module.js"
         async="" crossorigin="anonymous" type="module"></script>
         <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""
         crossorigin="anonymous" nomodule=""></script>

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
buildDuration	16.8s	15.3s	-1.5s
nodeModulesSize	48.5 MB	48.5 MB	-1.33 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
main-HASH.js	18.9 kB	18.9 kB	✓
main-HASH.js gzip	6.79 kB	6.79 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..9dda6167a.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..167a.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..3a0560775.js	43.2 kB	N/A	N/A
de003c3a9d30..0775.js gzip	15.5 kB	N/A	N/A
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
de003c3a9d30..1c22faff4.js	N/A	43.2 kB	N/A
de003c3a9d30..aff4.js gzip	N/A	15.5 kB	N/A
Overall change	211 kB	211 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
main-HASH.module.js	17.2 kB	17.2 kB	✓
main-HASH.module.js gzip	6.52 kB	6.52 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..72.module.js	45.6 kB	N/A	N/A
de003c3a9d30..dule.js gzip	16.5 kB	N/A	N/A
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
de003c3a9d30..c1.module.js	N/A	45.6 kB	N/A
de003c3a9d30..dule.js gzip	N/A	16.5 kB	N/A
Overall change	190 kB	190 kB	✓

Client Pages

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	rafaelalmeidatk/next.js update-inferno	Change
_error.js	254 kB	254 kB	-347 B
_error.js gzip	68 kB	68 kB	-39 B
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	979 B	978 B	-1 B
index.js	254 kB	254 kB	-347 B
index.js gzip	68.4 kB	68.3 kB	-42 B
link.js	262 kB	262 kB	-347 B
link.js gzip	70.4 kB	70.3 kB	-43 B
routerDirect.js	255 kB	255 kB	-347 B
routerDirect.js gzip	68.4 kB	68.4 kB	-46 B
withRouter.js	255 kB	255 kB	-347 B
withRouter.js gzip	68.5 kB	68.4 kB	-43 B
Overall change	1.28 MB	1.28 MB	-1.74 kB

Commit: 05be49b

Timer · 2019-10-16T05:24:39Z

Maybe it's time to retire this example? Should we delete it entirely?

Timer · 2019-10-16T05:27:24Z

See #9079 for inspiration!

lfades

Thank you @rafaelalmeidatk. I still think we can improve this examples in the future to remove the custom server, but because it's currently not possible, let's keep it updated until we have a better solution 👍

rafaelalmeidatk · 2019-10-17T03:16:12Z

@Timer If Next.js requires Suspense to work (packages/next/bin/next.ts line 95) then Inferno at the current state is technically incompatible. Idk why but this check doesn't throw in production so it still works.

Update: ok it doesn't really work if you try to use any of Inferno's API, so I see little point using it with Next. If we decide to remove the example, would it be a PR removing all the example files or a deprecation note in the example's README?

lfades · 2019-10-17T03:50:32Z

@rafaelalmeidatk In that case, let's remove it

rafaelalmeidatk added 2 commits October 11, 2019 02:12

Update inferno examples to v7.3

cf07abb

Add polyfill for React.createContext

cd9bdca

rafaelalmeidatk requested review from lfades and Timer as code owners October 11, 2019 06:32

lfades requested changes Oct 11, 2019

View reviewed changes

Alias react and react-dom with inferno-compat

fb74ebf

Fix linter errors

ece656f

Add warning about hooks and suspense support

05be49b

lfades approved these changes Oct 16, 2019

View reviewed changes

lfades merged commit 52023fe into vercel:canary Oct 16, 2019

rafaelalmeidatk deleted the update-inferno branch October 17, 2019 02:33

rafaelalmeidatk mentioned this pull request Oct 17, 2019

[using-inferno] Remove example #9108

Merged

snyk-bot mentioned this pull request Nov 25, 2019

[Snyk] Upgrade next from 9.0.4 to 9.1.3 ajesse11x/now-examples#17

Open

vercel locked as resolved and limited conversation to collaborators Feb 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[using-inferno] Update inferno to v7.3, fix missing React.createContext function #9038

[using-inferno] Update inferno to v7.3, fix missing React.createContext function #9038

rafaelalmeidatk commented Oct 11, 2019 •

edited

Loading

ijjk commented Oct 11, 2019

lfades left a comment •

edited

Loading

rafaelalmeidatk commented Oct 12, 2019

ijjk commented Oct 12, 2019

Diffs

ijjk commented Oct 12, 2019

Diffs

rafaelalmeidatk commented Oct 12, 2019 •

edited

Loading

ijjk commented Oct 15, 2019

Diffs

Timer commented Oct 16, 2019

Timer commented Oct 16, 2019

lfades left a comment

rafaelalmeidatk commented Oct 17, 2019

lfades commented Oct 17, 2019

[using-inferno] Update inferno to v7.3, fix missing React.createContext function #9038

[using-inferno] Update inferno to v7.3, fix missing React.createContext function #9038

Conversation

rafaelalmeidatk commented Oct 11, 2019 • edited Loading

ijjk commented Oct 11, 2019

Stats from current PR

lfades left a comment • edited Loading

Choose a reason for hiding this comment

rafaelalmeidatk commented Oct 12, 2019

ijjk commented Oct 12, 2019

Stats from current PR

Diffs

ijjk commented Oct 12, 2019

Stats from current PR

Diffs

rafaelalmeidatk commented Oct 12, 2019 • edited Loading

ijjk commented Oct 15, 2019

Stats from current PR

Diffs

Timer commented Oct 16, 2019

Timer commented Oct 16, 2019

lfades left a comment

Choose a reason for hiding this comment

rafaelalmeidatk commented Oct 17, 2019

lfades commented Oct 17, 2019

rafaelalmeidatk commented Oct 11, 2019 •

edited

Loading

lfades left a comment •

edited

Loading

rafaelalmeidatk commented Oct 12, 2019 •

edited

Loading