Update checking for existing dotenv usage #11496

ijjk · 2020-03-30T16:03:52Z

This updates our check for dotenv already being installed on a project to also check higher up package.jsons in case the app is inside of a monorepo. It currently checks higher up by looking for either a yarn.lock or lerna.json and then reading the package.json at the same depth. I also added tests to ensure this opts-out the dotenv usage correctly with this structure

Fixes: #11449

ijjk · 2020-03-30T16:10:04Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
buildDuration	9.8s	9.9s	⚠️ +108ms
nodeModulesSize	52.8 MB	52.8 MB	⚠️ +1.11 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
index.html gzip	916 B	916 B	✓
link.html gzip	925 B	925 B	✓
withRouter.html gzip	914 B	914 B	✓
Overall change	2.75 kB	2.75 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
buildDuration	10.5s	10.4s	-29ms
nodeModulesSize	52.8 MB	52.8 MB	⚠️ +1.11 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
_error.js gzip	294 kB	294 kB	-311 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	957 B	957 B	✓
index.js gzip	294 kB	294 kB	⚠️ +555 B
link.js gzip	301 kB	302 kB	⚠️ +602 B
routerDirect.js gzip	300 kB	300 kB	-121 B
withRouter.js gzip	300 kB	300 kB	-151 B
Overall change	1.49 MB	1.49 MB	⚠️ +574 B

zanettin · 2020-03-30T19:20:36Z

thanks a lot for the quick fix! works great on my end 👍

packages/next/lib/load-env-config.ts

# Conflicts: # packages/next/lib/load-env-config.ts

ijjk · 2020-03-31T16:09:22Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
buildDuration	9.8s	10s	⚠️ +213ms
nodeModulesSize	47.7 MB	47.7 MB	⚠️ +1.44 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.3 kB	56.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
index.html gzip	920 B	920 B	✓
link.html gzip	928 B	928 B	✓
withRouter.html gzip	916 B	916 B	✓
Overall change	2.76 kB	2.76 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
buildDuration	10.5s	10.7s	⚠️ +239ms
nodeModulesSize	47.7 MB	47.7 MB	⚠️ +1.44 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.3 kB	56.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/NEXT-153	Change
_error.js gzip	233 kB	232 kB	-88 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	960 B	960 B	✓
index.js gzip	232 kB	232 kB	⚠️ +250 B
link.js gzip	242 kB	243 kB	⚠️ +84 B
routerDirect.js gzip	241 kB	241 kB	-36 B
withRouter.js gzip	241 kB	240 kB	-103 B
Overall change	1.19 MB	1.19 MB	⚠️ +107 B

Update checking for existing dotenv usage

23ea3c0

ijjk added this to the 9.3.4 milestone Mar 30, 2020

ijjk requested review from lfades, Timer and timneutkens as code owners March 30, 2020 16:03

Timer reviewed Mar 31, 2020

View reviewed changes

packages/next/lib/load-env-config.ts Outdated Show resolved Hide resolved

ijjk added 2 commits March 31, 2020 11:00

Merge remote-tracking branch 'upstream/canary' into add/NEXT-153

5d3916f

# Conflicts: # packages/next/lib/load-env-config.ts

Check for package-lock.json also

0b495c7

ijjk requested a review from Timer March 31, 2020 16:02

timneutkens approved these changes Mar 31, 2020

View reviewed changes

Timer approved these changes Mar 31, 2020

View reviewed changes

ijjk merged commit b307ed9 into vercel:canary Mar 31, 2020

ijjk deleted the add/NEXT-153 branch March 31, 2020 16:27

snyk-bot mentioned this pull request Apr 13, 2020

[Snyk] Upgrade next from 9.3.2 to 9.3.4 yowainwright/Advanced-React#46

Merged

This was referenced Apr 24, 2020

[Snyk] Upgrade next from 9.3.3 to 9.3.4 willemliu/static-next#2

Closed

[Snyk] Upgrade next from 9.3.3 to 9.3.4 zagrajmy/frontend#163

Open

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update checking for existing dotenv usage #11496

Update checking for existing dotenv usage #11496

ijjk commented Mar 30, 2020

ijjk commented Mar 30, 2020

zanettin commented Mar 30, 2020 •

edited

Loading

ijjk commented Mar 31, 2020

Update checking for existing dotenv usage #11496

Update checking for existing dotenv usage #11496

Conversation

ijjk commented Mar 30, 2020

ijjk commented Mar 30, 2020

Stats from current PR

zanettin commented Mar 30, 2020 • edited Loading

ijjk commented Mar 31, 2020

Stats from current PR

zanettin commented Mar 30, 2020 •

edited

Loading