Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove passing of NODE_OPTIONS='--inspect' to subprocesses #11041

Merged
merged 3 commits into from
Apr 1, 2020
Merged

Remove passing of NODE_OPTIONS='--inspect' to subprocesses #11041

merged 3 commits into from
Apr 1, 2020

Conversation

vvo
Copy link
Member

@vvo vvo commented Mar 13, 2020 •
edited
Loading

fixes #11030

To test:

{
  "name": "test",
  "version": "0.1.0",
  "private": true,
  "scripts": {
    "dev": "NODE_OPTIONS='--inspect' next dev",
    "build": "next build",
    "start": "next start"
  },
  "dependencies": {
    "next": "9.3.0",
    "react": "16.13.0",
    "react-dom": "16.13.0"
  }
}
yarn dev

This will also solve #10807

@vvo vvo mentioned this pull request Mar 13, 2020
Closed
@ijjk
Copy link
Member

ijjk commented Mar 13, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
buildDuration 11.1s 11.3s ⚠️ +160ms
nodeModulesSize 56.6 MB 56.6 MB ⚠️ +778 B
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
index.html gzip 914 B 914 B ✓
link.html gzip 922 B 922 B ✓
withRouter.html gzip 910 B 910 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
buildDuration 12.4s 12.2s -152ms
nodeModulesSize 56.6 MB 56.6 MB ⚠️ +778 B
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_error.js gzip 293 kB 293 kB -3 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 954 B 954 B ✓
index.js gzip 293 kB 293 kB -61 B
link.js gzip 301 kB 301 kB ⚠️ +547 B
routerDirect.js gzip 300 kB 300 kB -50 B
withRouter.js gzip 300 kB 299 kB -49 B
Overall change 1.49 MB 1.49 MB ⚠️ +384 B

@ijjk
Copy link
Member

ijjk commented Mar 13, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
buildDuration 9.6s 10s ⚠️ +356ms
nodeModulesSize 56.6 MB 56.6 MB ⚠️ +778 B
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
index.html gzip 914 B 914 B ✓
link.html gzip 922 B 922 B ✓
withRouter.html gzip 910 B 910 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
buildDuration 10.5s 10.5s -19ms
nodeModulesSize 56.6 MB 56.6 MB ⚠️ +778 B
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_error.js gzip 293 kB 294 kB ⚠️ +707 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 954 B 954 B ✓
index.js gzip 294 kB 293 kB -189 B
link.js gzip 301 kB 301 kB -425 B
routerDirect.js gzip 300 kB 300 kB -4 B
withRouter.js gzip 300 kB 300 kB ⚠️ +309 B
Overall change 1.49 MB 1.49 MB ⚠️ +398 B

@ijjk
Copy link
Member

ijjk commented Mar 13, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
buildDuration 9.4s 9.6s ⚠️ +180ms
nodeModulesSize 56.6 MB 56.6 MB ⚠️ +778 B
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
index.html gzip 916 B 916 B ✓
link.html gzip 925 B 925 B ✓
withRouter.html gzip 913 B 913 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
buildDuration 10.3s 10.2s -95ms
nodeModulesSize 56.6 MB 56.6 MB ⚠️ +778 B
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.96 kB 2.96 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.06 kB 2.06 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_error.js gzip 293 kB 294 kB ⚠️ +763 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 957 B 957 B ✓
index.js gzip 294 kB 294 kB ⚠️ +390 B
link.js gzip 301 kB 301 kB ⚠️ +502 B
routerDirect.js gzip 300 kB 300 kB -101 B
withRouter.js gzip 300 kB 300 kB ⚠️ +268 B
Overall change 1.49 MB 1.49 MB ⚠️ +1.82 kB

@GabrielDelepine
Copy link

GabrielDelepine commented Mar 13, 2020 •
edited
Loading

For instance :
Screenshot 2020-03-13 at 18 34 41

process.env.NODE_OPTIONS.replace('--inspect', '') does not remove the option totally. I think we will have to use a regex (Using a package specialise to manipulate parameters would be preferable)

Removing it totally fix the issue for me , but the warning Starting inspector on 127.0.0.1:9876 failed: address already in use is still displayed once

@vvo
Copy link
Member Author

vvo commented Mar 13, 2020

process.env.NODE_OPTIONS.replace('--inspect', '') does not remove the option totally. I think we will have to use a regex (Using a package specialise to manipulate parameters would be preferable)

Definitely right, I'll give it another take later. At least we know where the bug lies now.

Removing it totally fix the issue for me, but the warning Starting inspector on 127.0.0.1:9876 failed: address already in use is still displayed once

I do not get the warning, maybe you have other processes running or some phamtom processes too?

see:

image

Try on a fresh new project maybe?

@GabrielDelepine
Copy link

I do not get the warning, maybe you have other processes running or some phamtom processes too?

You are right!
I had to close VSCODE, no more warning now. Everything is fine

aleclarson
aleclarson reviewed Mar 15, 2020
View reviewed changes
packages/next/server/next-dev-server.ts Outdated
// discard process.env.NODE_OPTIONS --inspect flag otherwise two debuggers are started in inspect
// mode when users will try to debug their Next.js application with NODE_OPTIONS='--inspect' next dev
NODE_OPTIONS: process.env.NODE_OPTIONS
? process.env.NODE_OPTIONS.replace('--inspect', '')
Copy link
Contributor

@aleclarson aleclarson Mar 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed here: vvo#1

edit: There seems to be another child process be spawned somewhere, because I'm still seeing the warning.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Downgrading to v8.1.0 fixed the issue

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overriding process.env.NODE_OPTIONS seems to do the job:
aleclarson@0248a44

Apart from "purity", is there any reason this approach should be avoided?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from "purity", is there any reason this approach should be avoided?

I think its fine, the feature of debugging a Next.js application for end users outweights the "purity" question for me. Sorry I have no time left to properly fix this but we know where the bug is at least, if someone from Next.js jumps in we'll see

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with my fix, I'm still unable to set breakpoints in my pages/api functions. :(

@vvo vvo force-pushed the fix/next-dev-server-inspect branch from 377a5b8 to adf7a30 Compare March 19, 2020 05:11
@ijjk
Copy link
Member

ijjk commented Mar 19, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
buildDuration 11.2s 11.8s ⚠️ +523ms
nodeModulesSize 53.2 MB 53.2 MB ⚠️ +778 B
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
index.html gzip 916 B 916 B ✓
link.html gzip 924 B 924 B ✓
withRouter.html gzip 913 B 913 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
buildDuration 12.5s 12.2s -268ms
nodeModulesSize 53.2 MB 53.2 MB ⚠️ +778 B
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_error.js gzip 293 kB 293 kB ⚠️ +313 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 957 B 957 B ✓
index.js gzip 293 kB 293 kB -4 B
link.js gzip 301 kB 301 kB ⚠️ +50 B
routerDirect.js gzip 300 kB 300 kB -334 B
withRouter.js gzip 299 kB 300 kB ⚠️ +483 B
Overall change 1.49 MB 1.49 MB ⚠️ +508 B

@vvo vvo force-pushed the fix/next-dev-server-inspect branch 3 times, most recently from c7ac253 to 6c48e82 Compare March 19, 2020 06:22
@ijjk
Copy link
Member

ijjk commented Mar 19, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
buildDuration 9.8s 10s ⚠️ +244ms
nodeModulesSize 53.2 MB 53.2 MB ⚠️ +1.52 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
index.html gzip 916 B 916 B ✓
link.html gzip 924 B 924 B ✓
withRouter.html gzip 913 B 913 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
buildDuration 10.5s 10.6s ⚠️ +138ms
nodeModulesSize 53.2 MB 53.2 MB ⚠️ +1.52 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_error.js gzip 294 kB 293 kB -385 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 957 B 957 B ✓
index.js gzip 294 kB 294 kB -100 B
link.js gzip 301 kB 301 kB -665 B
routerDirect.js gzip 300 kB 300 kB -181 B
withRouter.js gzip 300 kB 300 kB -222 B
Overall change 1.49 MB 1.49 MB -1.55 kB

@ijjk
Copy link
Member

ijjk commented Mar 19, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
buildDuration 7.7s 7.8s ⚠️ +127ms
nodeModulesSize 53.2 MB 53.2 MB ⚠️ +1.52 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
index.html gzip 916 B 916 B ✓
link.html gzip 924 B 924 B ✓
withRouter.html gzip 913 B 913 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
buildDuration 8.3s 8.3s ⚠️ +54ms
nodeModulesSize 53.2 MB 53.2 MB ⚠️ +1.52 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_error.js gzip 293 kB 293 kB ⚠️ +57 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 957 B 957 B ✓
index.js gzip 293 kB 294 kB ⚠️ +438 B
link.js gzip 301 kB 301 kB ⚠️ +331 B
routerDirect.js gzip 300 kB 299 kB -555 B
withRouter.js gzip 300 kB 300 kB -54 B
Overall change 1.49 MB 1.49 MB ⚠️ +217 B

@vvo vvo force-pushed the fix/next-dev-server-inspect branch from 6c48e82 to 86ccdc5 Compare March 19, 2020 06:25
@vvo
Copy link
Member Author

vvo commented Mar 19, 2020

ok @timneutkens I've fixed the code here and added a test as for --inspect.

cc @aleclarson this uses your regex commit too.

@vvo vvo force-pushed the fix/next-dev-server-inspect branch from 86ccdc5 to eaed6ab Compare March 19, 2020 06:30
@ijjk
Copy link
Member

ijjk commented Mar 19, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
buildDuration 10.9s 11s ⚠️ +94ms
nodeModulesSize 53.2 MB 53.2 MB ⚠️ +1.52 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
index.html gzip 916 B 916 B ✓
link.html gzip 924 B 924 B ✓
withRouter.html gzip 913 B 913 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
buildDuration 12s 11.9s -57ms
nodeModulesSize 53.2 MB 53.2 MB ⚠️ +1.52 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_error.js gzip 294 kB 293 kB -679 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 957 B 957 B ✓
index.js gzip 294 kB 293 kB -187 B
link.js gzip 301 kB 301 kB -113 B
routerDirect.js gzip 299 kB 299 kB -20 B
withRouter.js gzip 300 kB 300 kB ⚠️ +304 B
Overall change 1.49 MB 1.49 MB -695 B

@vvo
Copy link
Member Author

vvo commented Mar 19, 2020

Side note: I wonder if we should maybe re-introduce the --inspect flag or better like a --debug flag that would then start the debugger internally. So we would not even have to fiddle with NODE_OPTIONS internally. Not sure this is doable though.

Also, I did try to go using https://github.com/zeit/arg but:

  • no easy way to handle --inspect --inspect=value (it's either one or the other)
  • no way to turn the args back into a string (NODE_OPTIONS: String => arg => remove --inspect => NODE_OPTIONS: String)

So I went for the regex even if I am allergic (read: bad) to them :D. But @aleclarson did a good one

@ijjk
Copy link
Member

ijjk commented Mar 19, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
buildDuration 9.5s 9.7s ⚠️ +206ms
nodeModulesSize 53.2 MB 53.2 MB ⚠️ +1.52 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
index.html gzip 916 B 916 B ✓
link.html gzip 924 B 924 B ✓
withRouter.html gzip 913 B 913 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
buildDuration 10.3s 10.6s ⚠️ +399ms
nodeModulesSize 53.2 MB 53.2 MB ⚠️ +1.52 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary vvo/next.js fix/next-dev-server-inspect Change
_error.js gzip 293 kB 294 kB ⚠️ +263 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 957 B 957 B ✓
index.js gzip 293 kB 294 kB ⚠️ +276 B
link.js gzip 301 kB 301 kB -336 B
routerDirect.js gzip 299 kB 300 kB ⚠️ +420 B
withRouter.js gzip 300 kB 300 kB -23 B
Overall change 1.49 MB 1.49 MB ⚠️ +600 B

@GuillaumeDesforges
Copy link

Looking forward for this fix, thank you so much.
Any idea for a release date ?

pom421 added a commit to SocialGouv/medle that referenced this pull request Mar 27, 2020
@pom421
fix: downgrade on Next 9.2 since debug bug in 9.3
28604d9 
See vercel/next.js#11041
fix
This was referenced Apr 24, 2020
Closed
Open
This was referenced Mar 28, 2021
Open
Open
Open
Open
This was referenced Sep 12, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 17, 2022
Open
Open
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aleclarson aleclarson aleclarson approved these changes

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot start node inspector: "address already in use"
7 participants
@vvo @ijjk @GabrielDelepine @GuillaumeDesforges @timneutkens @Hainesy @aleclarson