Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node.js 12 CI #525

Merged
merged 5 commits into from
Mar 27, 2020
Merged

Add Node.js 12 CI #525

merged 5 commits into from
Mar 27, 2020

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Mar 27, 2020 •
edited by styfle
Loading

Update dependencies and add Node.js 12 to CI matrix.

@guybedford guybedford requested review from styfle and Timer as code owners March 27, 2020 19:12
styfle
styfle reviewed Mar 27, 2020
View reviewed changes
test/index.test.js Outdated Show resolved Hide resolved
@guybedford guybedford changed the title WIP: Node.js 12 CI Node.js 12 CI Mar 27, 2020
styfle
styfle approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! If this passes, then we can do the same on node-file-trace 👍

@styfle styfle added the automerge Automatically merge PR once checks pass label Mar 27, 2020
@styfle styfle mentioned this pull request Mar 27, 2020
Closed
@styfle styfle changed the title Node.js 12 CI Add Node.js 12 CI Mar 27, 2020
@kodiakhq kodiakhq bot merged commit 93b5969 into master Mar 27, 2020
@kodiakhq kodiakhq bot deleted the node-12 branch March 27, 2020 22:10
@guybedford guybedford mentioned this pull request Mar 27, 2020
Merged
This was referenced Mar 12, 2021
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
automerge Automatically merge PR once checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guybedford @styfle