Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project_panel::NewSearchInDirectory should work on files not just folders #23383

Closed
1 task done
notpeter opened this issue Jan 20, 2025 · 0 comments · Fixed by #23696
Closed
1 task done

project_panel::NewSearchInDirectory should work on files not just folders #23383

notpeter opened this issue Jan 20, 2025 · 0 comments · Fixed by #23696
Labels
bite-size small issues bug [core label] good first issue Issue suitable for first-time contributors project panel Feedback for files tree view search buffer search, project search, etc

Comments

@notpeter
Copy link
Member

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Steps to reproduce:

  1. Click on a file in the project panel.
  2. Trigger the project_panel::NewSearchInDirectory action (cmd-shift-f)
  3. Note nothing happens.

Expected: Search all files is spawned with include set to the parent directory of the current file.

Zed Version and System Specs

Zed: v0.171.0 (Zed Nightly 7302be8)
OS: macOS 15.2.0
Memory: 64 GiB
Architecture: aarch64

If applicable, add screenshots or screencasts of the incorrect state / behavior

No response

If applicable, attach your Zed.log file to this issue.

N/A
@notpeter notpeter added admin read bug [core label] project panel Feedback for files tree view good first issue Issue suitable for first-time contributors bite-size small issues search buffer search, project search, etc and removed triage labels Jan 20, 2025
@github-actions github-actions bot mentioned this issue Jan 21, 2025
Open
@wblazer wblazer mentioned this issue Jan 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bite-size small issues bug [core label] good first issue Issue suitable for first-time contributors project panel Feedback for files tree view search buffer search, project search, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix project_panel::NewSearchInDirectory to work on files wblazer/zed
1 participant
@notpeter