Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor names are cut off in Vim normal mode during collaboration #21887

Open
1 task done
AaronFeickert opened this issue Dec 11, 2024 · 5 comments · May be fixed by #21999
Open
1 task done

Cursor names are cut off in Vim normal mode during collaboration #21887

AaronFeickert opened this issue Dec 11, 2024 · 5 comments · May be fixed by #21999
Labels
bug [core label] collaboration The umbrella label for all collaboration features editor Feedback for code editing, formatting, editor iterations, etc vim

Comments

@AaronFeickert
Copy link
Contributor

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

When collaborating with a user editing in Vim normal mode (where a block cursor symbol is used), the user's name pops up from time to time for identification purposes. When this happens, the first letter of the name is partially cut off due to overlap with the character under the cursor.

This does not happen in insert mode, or when Vim modes are disabled.

Environment

Zed: v0.165.4 (Zed)
OS: macOS 15.1.1
Memory: 18 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log
@AaronFeickert AaronFeickert added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Dec 11, 2024
@AaronFeickert
Copy link
Contributor Author

I'm new to the codebase, but I wonder if the issue is with the cursor layout implementation.

@JosephTLyons JosephTLyons added collaboration The umbrella label for all collaboration features vim editor Feedback for code editing, formatting, editor iterations, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Dec 12, 2024
@github-actions github-actions bot mentioned this issue Dec 13, 2024
Open
@AaronFeickert
Copy link
Contributor Author

AaronFeickert commented Dec 14, 2024 •
edited
Loading

This isn't specific to Vim normal mode.

When the cursor is at the top line, the name popup is positioned at the right side of the cursor, and no overlap is visible. But when it is on any other line, it is positioned at the left side of the cursor, and an overlap occurs. In practice, this only affects block-shaped cursors, which is why it is particularly noticeable in Vim normal mode.

Here's an example of the overlap in action:
Screenshot 2024-12-13 at 18 00 54

@AaronFeickert AaronFeickert linked a pull request Dec 14, 2024 that will close this issue
Open
@ConradIrwin
Copy link
Member

I think we could fix this by rendering the cursor's background before the name, but I haven't looked at the details.

@AaronFeickert
Copy link
Contributor Author

@ConradIrwin: is there any reason why the linked PR doesn't suffice?

@ConradIrwin
Copy link
Member

Sorry I missed that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug [core label] collaboration The umbrella label for all collaboration features editor Feedback for code editing, formatting, editor iterations, etc vim
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cursor overlap AaronFeickert/zed
3 participants
@ConradIrwin @JosephTLyons @AaronFeickert