Esc not working when binding

[gdandersson]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

Coming from Textmate, binding escape to completions is a given. But.. binding this in the editor context also makes it impossible to escape/close cmd + t (Search project files..), cmd + shift + p (Execute a command), ctrl + g (Go to line) etc without using the mouse.

I would assume binding escape in the editor didn't affect "popups"/windows, only when editing.

    "bindings": {
      "escape": "editor::ShowCompletions"
    }

Environment

Zed: v0.150.4 (Zed)
OS: macOS 14.5.0
Memory: 32 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log

[notpeter]

You've created a global shortcut (no context) you should be able to limit it just to the Editor scope by adding a "context".

  {
    "context": "Editor",
    "bindings": {
      "escape": "editor::ShowCompletions"
    }
  },

See Key Bindings: Context in the docs.

You can look at the source for more examples for examples of the appropriate context for different shortcuts: assets/keymaps/macos/atom.json and assets/keymaps/default-macos.json

[gdandersson]

That wasn't the full keymap.json. Attaching it here to show that it's within the editor context:

[
	{
		"context": "Workspace",
		"bindings": {
			// "shift shift": "file_finder::Toggle"
		}
	},
	{
		"context": "Editor",
		"bindings": {
			// "j k": ["workspace::SendKeystrokes", "escape"]
			"escape": "editor::ShowCompletions"
		}
	}
]

[notpeter]

Gotcha. I can reproduce with that keymap. I'm not sure what's the appropriate context for restoring this behavior (none of what I tried worked). For more see:

• Document keymap context #14718

We have multiple redundant mappings for escape, so as a workaround you could use cmd-esc, ctrl-esc or ctrl-c to cancel those menus:

zed/assets/keymaps/default-macos.json

Lines 22 to 25 in 3256387

	"escape": "menu::Cancel",
	"cmd-escape": "menu::Cancel",
	"ctrl-escape": "menu::Cancel",
	"ctrl-c": "menu::Cancel",