Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese characters are corrupted after unpacking HTML docset #508

Closed
zjzdy opened this issue Mar 5, 2016 · 9 comments
Closed

Chinese characters are corrupted after unpacking HTML docset #508

zjzdy opened this issue Mar 5, 2016 · 9 comments

Comments

@zjzdy
Copy link

zjzdy commented Mar 5, 2016

My system is Windows 7 zh_CN.
System default code is GBK.
In HTML.tgz\HTML.docset\Contents\Resources\Documents\mdn.mozillademos.org\zh-CN\docs\Web\HTML\Element\datalist$samples\ have a file is 示例426e.html.But file name is ê?ày426e.html in system.
4

Then std::ifstream can't find file and QIODevice::read: device not open.

@DerekTurtleRoe
Copy link

@zjzdy Does this happen on an English Windows 7?

@zjzdy
Copy link
Author

zjzdy commented Mar 13, 2016

@vgturtle127 I don't know.Because I hadn't installed English Windows.You can try it.

@DerekTurtleRoe
Copy link

@zjzdy I am using Windows 10, so I don't know if the problem will exist since localization has changed a lot since Windows 7...

@trollixx trollixx reopened this Mar 21, 2016
@trollixx
Copy link
Member

Don't look in the commit above, it's not relevant, and does not include my attempt to fix the issue.

It looks like that there's no good way to fix this problem until an issue in libarchive is resolved.

@trollixx
Copy link
Member

Looks like I've missed archive_entry_pathname_w(), which is hacky, but should fix the issue on Windows.

@DerekTurtleRoe
Copy link

@trollixx Oh, thanks. I had no idea!

@trollixx trollixx changed the title Extract HTML.tgz have file name error in Zeal. Chinese characters are corrupted after unpacking HTML docset Mar 27, 2016
@trollixx
Copy link
Member

@zjzdy where exactly does your HTML.docset come from?

@trollixx
Copy link
Member

I've committed a workaround, but I am unable to test it. Please grab a CI build, and test. Let me know if the problem is solved or not.

@lock
Copy link

lock bot commented Sep 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for a related request.

@lock lock bot locked and limited conversation to collaborators Sep 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants