feat(delete): fix unsetting plugin state & add --debug / --quiet flags
#622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue when deleting a plugin did not unset variables containing plugin state. This manifested in incorrect command output. Add `-d/--debug` && `-q/--quiet` flags to `delete` command. * `--debug` flag enables xtrace for the currect delete command invocation * `--quiet` flag suppresses some output Signed-off-by: Vladislav Doster <[email protected]>
vladdoster
force-pushed
the
fix/delete-command
branch
from
5e425aa to
73fc28b
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
# [3.13.0](v3.12.1...v3.13.0) (2024-01-18) ### Bug Fixes * **ci:** remove duplicate gh-r zunit job ([#623](#623)) ([70cefc0](70cefc0)) * debug logging logic and format ([#592](#592)) ([3c7e5be](3c7e5be)) * handle zinit --help ([#597](#597)) ([8cf9104](8cf9104)) * link ice check in .zinit-download-snippet function ([#608](#608)) ([358ef03](358ef03)) * pin dua gh-r test to v2.20.3 ([#605](#605)) ([0ba778a](0ba778a)) * silence unzip command in ziextract ([#614](#614)) ([71764bf](71764bf)) * tar permissions when `ziextract` ran as root user ([#557](#557)) ([e2d477c](e2d477c)) * update labeler config to v5 ([#604](#604)) ([794723c](794723c)) ### Features * configure, make, cmake, and build ices ([#613](#613)) ([#616](#616)) ([22e66db](22e66db)) * **delete:** fix unsetting plugin state & add `--debug` / `--quiet` flags ([#622](#622)) ([3f4b685](3f4b685)) * remove zpextract and use ziextract ([#611](#611)) ([2ccac85](2ccac85))
|
🎉 This PR is included in version 3.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue when deleting a plugin did not unset variables containing plugin state. This manifested in incorrect command output.
Add
--debug&&--quietflags todeletecommand.--debugflag enables xtrace for the currect delete command invocation--quietflag suppresses some outputRelated Issue(s)
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: