Fix #395 #397
Merged
Fix #395 #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freed-Wu
requested review from
alichtman,
pschmitt and
vladdoster
as code owners
|
I understand the reason, but I can't think of a situation where |
Exist, such as user use |
|
Can you rebase your branch onto main so the checks will pass? |
|
OK. |
|
Seems that some test failed. |
|
What happened? @vladdoster |
Is it due to network problem? Can anyone rerun the test to take a look? |
|
Don't. Fix the ci instead. |
|
Your branch is out of date. Rebase your branch using the zdharma-continuum main branch. |
|
I went ahead and rebased your branch. |
|
Don't worry about the numerous commits. I'll merge this once unit tests pass and will regenerate the docs in a separate PR. Thanks again for your PR :^) |
close #395 fix wrong lines of zsdoc
|
All checks have passed. |
pschmitt
reviewed
Apr 4, 2023
pschmitt
approved these changes
Apr 4, 2023
vladdoster
added a commit
that referenced
this pull request
Apr 8, 2023
…397) Zinit creates a directory named `._zinit` to store metadata. However, this metadata should not be added to git. Closes #395 Signed-off-by: wzy <[email protected]> Co-authored-by: vladislav doster <[email protected]>
vladdoster
added a commit
that referenced
this pull request
Apr 8, 2023
…ory (#397) Zinit creates a directory named `._zinit` to store metadata. However, this metadata should not be added to git. Closes #395 Signed-off-by: wzy <[email protected]> Co-authored-by: Vladislav Doster <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
May 4, 2023
# [3.11.0](v3.10.0...v3.11.0) (2023-05-04) ### Bug Fixes * add `.gitignore` with '*' pattern in a plugins `._zinit/` directory ([#397](#397)) ([fccb508](fccb508)), closes [#395](#395) * broken update command ([336ca85](336ca85)) * cleanup style, naming, and completion ([6c82d67](6c82d67)) * compile and completion log messages ([c4446da](c4446da)) * csearch ignores lua files ([4d1840b](4d1840b)) * makefile clean target less verbose ([3396f5e](3396f5e)) * pin git-mkver gh-r test to v.1.2.2 ([a05cc1a](a05cc1a)) * pin git-mkver unit test to v1.2.2 ([08f02e0](08f02e0)) * regenerate docs ([e0177e2](e0177e2)) ### Features * expand gh-r zunit tests ([c323116](c323116)) * refactor debug commands ([930b25e](930b25e)) * refactor ls, list, and loaded commands ([a865907](a865907))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create
._zinit/.gitignorewhich content is '*' for every plugin.Motivation and Context
zinit create
._zinitto store some metadata. However, this metadata should notbe added to git.
Related Issue(s)
Fix #395.
I am not sure if
https://github.com/zdharma-continuum/zinit/blob/main/share/template-plugin/zsh.gitignore#L12
should be removed. Maybe we should support old zinit? And I think this file
should be pushed to https://github.com/github/gitignore/ to let more zsh
plugin developers use.
How Has This Been Tested?
I have tested it can work for me.
Types of changes
Checklist: