Edition 2018 clean up#113
Merged
Merged
Conversation
Contributor
Author
|
There is a typo in one of the commit messages, and it looks like this will fail CI due needing a |
added 10 commits
August 20, 2019 18:19
Eirik0
force-pushed
the
edition-2018-clean-up
branch
from
56965a7 to
76795a9
Compare
Eirik0
commented
Aug 21, 2019
|
|
||
| impl ::std::fmt::Display for $affine { | ||
| fn fmt(&self, f: &mut ::std::fmt::Formatter) -> ::std::fmt::Result { | ||
| fn fmt(&self, f: &mut ::std::fmt::Formatter<'_>) -> ::std::fmt::Result { |
Contributor
Author
There was a problem hiding this comment.
Note: In pairing I did a find and replace on ::std::fmt::Formatter/::std::fmt::Formatter<'_>. cargo fix --edition-idioms would fail here and try to double add the <'_>.
str4d
requested changes
Aug 21, 2019
str4d
left a comment
str4d
left a comment
Contributor
There was a problem hiding this comment.
ACK mod comments, but zcash_proofs has not been editionized.
| #[cfg(feature = "multicore")] | ||
| extern crate crossbeam; | ||
| #[cfg(feature = "multicore")] | ||
| extern crate futures_cpupool; |
Contributor
There was a problem hiding this comment.
Why does this multicore-conditional extern crate disappear, but not the other two?
Contributor
There was a problem hiding this comment.
extern crate hex_literal stays as expected because of the #[macro_use].
| extern crate rand; | ||
|
|
||
| #[cfg(test)] | ||
| extern crate rand_xorshift; |
Contributor
There was a problem hiding this comment.
Why does this test-conditional extern crate disappear, but not the extern crate rand?
Co-Authored-By: str4d <thestr4d@gmail.com>
Contributor
Author
There were no changes when running |
str4d
approved these changes
Aug 22, 2019
Merged
ebfull
approved these changes
Aug 23, 2019
Merged
greg0x
pushed a commit
to valargroup/librustzcash
that referenced
this pull request
Mar 12, 2026
* Add Validator setup, automate app.toml update * Fix lucide-react title prop TS error on icon components Wrap ShieldCheck and ShieldAlert icons in <span> elements for the title attribute, since this lucide-react version doesn't accept title as a prop. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove chain-rounds references deleted on main ChainRoundsView and Server import were removed in main but incorrectly kept during merge conflict resolution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Show "Connect admin wallet" button in publish modal when no wallet connected Instead of showing an error after clicking publish, the modal now shows a "Connect admin wallet" button that navigates to Settings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix missing onGoToSettings destructure in PublishModal Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Show inline wallet connect in publish modal instead of navigating to settings When no wallet is connected, the publish modal now shows Keplr and dev-key connection options directly. Once connected it switches to the normal publish confirmation view. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove Downloads from sidebar Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove unused Download import from Sidebar Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR runs
cargo fix --editionandcargo fix --edition-idiomson all of the modules which needed it, and includes some warning cleanup along the way. The folderszcash_primitives/benches/...andpairing/benches/...were omitted when running the fix because they depend on unstable features, so it is possible that they no longer work. @ebfull suggested updating the benchmarks to use https://docs.rs/criterion/0.2.11/criterion/ which could be done as part of this PR, but might make more sense to be done as follow up.Closes #97.