Fix lint warnings: "lint intra_doc_link_resolution_failure has been renamed to broken_intra_doc_links"

[daira]

GitHub Actions / Nightly lint

ff/src/lib.rs#L5 and group/src/lib.rs#L2 :

lint `intra_doc_link_resolution_failure` has been renamed to `broken_intra_doc_links`

[str4d]

In the interim, we can pin a version of nightly before this change was made, if we want to avoid the lint warnings in other PRs.

[daira]

Well, that would mean that if any other warnings are added then we wouldn't see them. I think it's fine to just ignore these warnings for now. (I'm surprised that this is a warning at all before the broken_intra_doc_links replacement is in stable, tbh. Aren't you supposed to add something to stable and then deprecate the old thing?)

[str4d]

Apparently this is expected in the lint renaming process: rust-lang/rust#74926 (comment)

The standard fix would be to apply allow(unknown_lints) until rust-lang/rust#74430 is merged and we are on a stable release containing the stabilised lint.

[str4d]

We can rename the lints once our MSRV is 1.48.0.

[daira]

Rust 1.48.0 is nearly 3 months old; why not update the MSRV now? Those warnings really get in my way when reviewing.