Merge pull request #15 from taylorvance/patch-1

zbateson · web-flow · commit 681bcf1473e8 · 2024-12-20T14:00:04.000-08:00
Use explicit nullable type for PHP 8.4
diff --git a/src/MbWrapper.php b/src/MbWrapper.php
@@ -342,7 +342,7 @@ private function iconvStrlen(string $str, string $charset) : int
         return $ret;
     }
     
-    private function iconvSubstr(string $str, string $charset, int $start, int $length = null) : string
+    private function iconvSubstr(string $str, string $charset, int $start, ?int $length = null) : string
     {
         $ret = @\iconv_substr($str, $start, $length, $charset . '//TRANSLIT//IGNORE');
         if ($ret === false) {

Original file line number	Diff line number	Diff line change
`@@ -342,7 +342,7 @@ private function iconvStrlen(string $str, string $charset) : int`
`342`	`342`	`return $ret;`
`343`	`343`	`}`
`344`	`344`
`345`		`- private function iconvSubstr(string $str, string $charset, int $start, int $length = null) : string`
	`345`	`+ private function iconvSubstr(string $str, string $charset, int $start, ?int $length = null) : string`
`346`	`346`	`{`
`347`	`347`	`$ret = @\iconv_substr($str, $start, $length, $charset . '//TRANSLIT//IGNORE');`
`348`	`348`	`if ($ret === false) {`