-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting Zarr-Python 3 Codec API #502
Comments
cc @zarr-developers/python-core-devs |
@jhamman the link to the new codec API is 404... |
I fixed the OP. |
We discussed this in the Zarr-Python refactor meeting today. The outstanding task here is to experiment with Zarr v3 codec API by exposing this library's compression codecs and pre-compression filters through the This would be a good project for someone interested in getting involved in zarr-python 3's development. |
I would add here, that I think having some fallback support for numcodecs (+ other packages that make codecs following its API) is important to maintain readability of datasets in v3. We need to decide whether we can assume they work on bytes - which is by far the most common case - or otherwise can tell from the signature (or try/except) if they accept/produce arrays. That doesn't seem to hard. Question: codecs are of course CPU-bound, and will be run in threads, hoping that the GIL is released. The to_thread call lives in zarr-python? If all this is true, I don't see any reason to rewrite any codecs for v3, except where we wish to state the bytes Vs array nature of a codec. |
There is now a PR that adds the |
Removing the "good first issue" label since there's now a PR for this |
Over in Zarr-Python, we are working on a a new major version (v3). This version will have a slightly new Codec API and will expose a new set of codec types (
ArrayArrayCodec
,ArrayBytesCodec
,BytesBytesCodec
, etc.). These codec classes are not wildly different from the existing Numcodecs API (perhaps except for the partial encode/decode options) but they are not in perfect alignment. With this in mind, some questions for discussion:The text was updated successfully, but these errors were encountered: