go-lint pre-commit only applies to staged changes #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RothAndrew
suggested changes
Mar 11, 2022
RothAndrew
suggested changes
Mar 14, 2022
There was a problem hiding this comment.
Change
- repo: https://github.com/dnephin/pre-commit-golang
rev: v0.4.0
hooks:
- id: go-fmt
- repo: https://github.com/dnephin/pre-commit-golang
rev: v0.4.0
hooks:
- id: golangci-lintto
- repo: https://github.com/dnephin/pre-commit-golang
rev: v0.4.0
hooks:
- id: go-fmt
- id: golangci-lint
RothAndrew
previously approved these changes
Mar 14, 2022
YrrepNoj
force-pushed
the
update-lint-pre-commit-hook
branch
from
995a301 to
52227e1
Compare
|
@RothAndrew I had to re-push to fix a merge conflict, when you have a moment could you re-review? Thanks. |
RothAndrew
approved these changes
Mar 14, 2022
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
* lint pre-commit only applies to staged changes * using remote golangci/golangci-lint instead of a local hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current pre-commit hook applies linting to all of the *.go files in the repo. I think this was necessary back when we had multiple go.mod and go.sum files in the repo. Either way, it doesn't seem to be necessary anymore. Now the pre-commit config will only run the linting against files that are staged for commit. This also uses the same repo we use to run our other go pre-commit tasks.
NOTE: It will run against the entire file, not just the parts that have been updated.
This screenshot shows the pre-commit linting failing on only the file staged and not on the other linting issues we currently have:
