Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Big Bang example to latest version #346

Merged
merged 13 commits into from
Mar 8, 2022

Conversation

matt-strong
Copy link
Contributor

closes #235

@matt-strong
Copy link
Contributor Author

/test all

examples/big-bang/zarf.yaml Outdated Show resolved Hide resolved
examples/big-bang/zarf.yaml Outdated Show resolved Hide resolved
@RothAndrew
Copy link
Contributor

Keep in mind the testing pipeline for these changes is meaningless, since the Big Bang example isn't one of the examples that is tested. We are meaning to add it but it will need to be done strategically since it is very large and would increase the length of time that the testing pipeline takes to finish by a lot.

Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update images in the package too

@RothAndrew
Copy link
Contributor

@matt-strong and I talked and decided that it would be best to transition this off of his plate since it would not be able to be his 1st priority. We are going to get started on this work today as part of Dash Days since we believe it is a prerequisite to this issue, then I will finish it out next week. Given our need to also upgrade the big bang version in "DI2-ME" this work will be very valuable there as well.

"DI2-ME" issue: https://github.com/defenseunicorns/zarf-package-software-factory/issues/38

@RothAndrew RothAndrew self-assigned this Mar 4, 2022
@jeff-mccoy
Copy link
Contributor

makes sense, thanks @RothAndrew

@RothAndrew
Copy link
Contributor

image

image

image

image

image

image

image
not sure why there is a system time difference... probably a quirk of vagrant?

image

@RothAndrew
Copy link
Contributor

Ready for review and merge

@jeff-mccoy
Copy link
Contributor

Isn't pgl available now vs efk so we can properly test this in local distros? Is that a different issue already?

@RothAndrew
Copy link
Contributor

I'll write up a separate issue for it. I wanted this one to be just a straight version upgrade of what is already there to keep the scope small

@RothAndrew RothAndrew enabled auto-merge (squash) March 8, 2022 01:53
@jeff-mccoy
Copy link
Contributor

Makes sense to me

@jeff-mccoy jeff-mccoy removed the request for review from YrrepNoj March 8, 2022 02:29
@RothAndrew RothAndrew merged commit 74b38bd into master Mar 8, 2022
@RothAndrew RothAndrew deleted the features/upgrade_bb_again branch March 8, 2022 02:32
@RothAndrew RothAndrew changed the title upgrade big bang version to latest version Upgrade Big Bang example to latest version Mar 8, 2022
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Big Bang Example to latest version
4 participants