-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Big Bang example to latest version #346
Conversation
/test all |
Keep in mind the testing pipeline for these changes is meaningless, since the Big Bang example isn't one of the examples that is tested. We are meaning to add it but it will need to be done strategically since it is very large and would increase the length of time that the testing pipeline takes to finish by a lot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update images in the package too
@matt-strong and I talked and decided that it would be best to transition this off of his plate since it would not be able to be his 1st priority. We are going to get started on this work today as part of Dash Days since we believe it is a prerequisite to this issue, then I will finish it out next week. Given our need to also upgrade the big bang version in "DI2-ME" this work will be very valuable there as well. "DI2-ME" issue: https://github.com/defenseunicorns/zarf-package-software-factory/issues/38 |
makes sense, thanks @RothAndrew |
Ready for review and merge |
Isn't pgl available now vs efk so we can properly test this in local distros? Is that a different issue already? |
I'll write up a separate issue for it. I wanted this one to be just a straight version upgrade of what is already there to keep the scope small |
Makes sense to me |
closes #235