Check for a $KUBECONFIG env-variable #316
Conversation
|
It would be swell to see some type of test for this. Like maybe move the k3s kube config and set the env variable. |
| // use the current context in the default kubeconfig in the home path of the user | ||
| homePath, err := os.UserHomeDir() | ||
| if err != nil { | ||
| message.Fatal(nil, "Unable to load the current user's home directory") |
There was a problem hiding this comment.
What's the latest on doing this vs returning error? I thought at some point I had heard @jeff-mccoy say we were switching to returning error to make testing easier.
Though, I'm seeing right below this it doing the same thing, so maybe the question is whether a refactor of this method is warranted along with this change.
There was a problem hiding this comment.
we are moving towards bubbling errors, but that would be a larger refactor than this code right now, so I think this one is okay.
|
/test all |
YrrepNoj
force-pushed
the
315-kubeconfig-env
branch
from
e5f1c04 to
5bd8bcd
Compare
|
/test all |
|
/test all |
| // use the current context in the default kubeconfig in the home path of the user | ||
| homePath, err := os.UserHomeDir() | ||
| if err != nil { | ||
| message.Fatal(nil, "Unable to load the current user's home directory") |
There was a problem hiding this comment.
we are moving towards bubbling errors, but that would be a larger refactor than this code right now, so I think this one is okay.
This PR adds a check for the $KUBECONFIG environment variable when Zarf is trying to generate a config to talk to a native kubernetes cluster.
Closes #315