Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup OCI Image Config creation #1434

Closed
Noxsios opened this issue Mar 14, 2023 · 1 comment
Closed

Cleanup OCI Image Config creation #1434

Noxsios opened this issue Mar 14, 2023 · 1 comment

Comments

@Noxsios
Copy link
Contributor

Noxsios commented Mar 14, 2023

Describe what should be investigated or refactored

src/pkg/packager/publish.go has a generateManifestConfig function that could be modified. In essence it creates a OCI compliant Image Manifest Config when pushing Zarf packages as OCI Images. This config is not used and is pretty pointless (but is a requirement to create image manifests). If we wanted to consume this config and use it for Zarf things, it would need to be expanded and fleshed out.

Links to any relevant code

#1423 (comment)

Additional context

Add any other context or screenshots about the technical debt here.
@github-project-automation github-project-automation bot moved this to New Requests in Zarf Project Board Mar 14, 2023
@Noxsios Noxsios mentioned this issue Mar 14, 2023
Merged
5 tasks
@Noxsios Noxsios mentioned this issue Apr 29, 2023
Closed
@Racer159
Copy link
Contributor

With generateManifestConfig refactored was there more you wanted to do with this issue?

@Noxsios Noxsios closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Racer159 @Noxsios