Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative filepaths through composability #1097

Closed
3 tasks done
Racer159 opened this issue Dec 7, 2022 · 0 comments · Fixed by #1469
Closed
3 tasks done

Relative filepaths through composability #1097

Racer159 opened this issue Dec 7, 2022 · 0 comments · Fixed by #1469
Assignees
Labels
enhancement ✨ New feature or request

Comments

@Racer159
Copy link
Contributor

Racer159 commented Dec 7, 2022

Is your feature request related to a problem? Please describe.
We should implement relative file-paths for composable packages so that they can be imported correctly when developed and maintained by potentially different developers. Specifically this affects:

  • Local Charts
  • Data Injections
  • Actions

Describe the solution you'd like
Instead of needing to have the full filepath from the root zarf.yaml we should use the relative filepath from that child zarf yaml

Describe alternatives you've considered
We could leave it like it is but it will make some things difficult down the line (particularly remote composability)

Additional context
This is a breaking change

@RothAndrew RothAndrew moved this to New Requests in Zarf Project Board Dec 7, 2022
@Racer159 Racer159 added the enhancement ✨ New feature or request label Dec 7, 2022
@Racer159 Racer159 moved this from New Requests to Doing Now in Zarf Project Board Dec 7, 2022
@jeff-mccoy jeff-mccoy added this to the v0.25.x milestone Jan 17, 2023
@Racer159 Racer159 modified the milestones: v0.25.x, v0.25.y Feb 26, 2023
@Racer159 Racer159 modified the milestones: v0.25.x, v0.26-rc Mar 19, 2023
@Racer159 Racer159 modified the milestones: v0.26.0, v0.26.1 Apr 18, 2023
@Racer159 Racer159 modified the milestones: v0.26 (m2), v0.27 (m1) Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants