Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version that support Boost 1.70 and beyond #862

Closed
aholzinger opened this issue Jan 18, 2020 · 5 comments
Closed

New version that support Boost 1.70 and beyond #862

aholzinger opened this issue Jan 18, 2020 · 5 comments

Comments

@aholzinger
Copy link

Hi, what is the blocker in creating a new version that considers the issues with boost::asio since version 1.70?

I'm aware that the develop branch addressed this issue, but the situation is far from being perfect, especially if you use libraries/repos that include websocketpp like i.e. cpprestsdk.

Attached is a patch for master that works with boost >= 1.70, tested under Windows by compiling the cpprestsdk (VS2017 and boost 1.170, VS2019 and bost 1.71 and 1.72).

I know the patch is far from optimal, but it already would help all the cpprestsdk users that can't downgrade to boost 1.69.
0001-Make-websocketpp-usable-with-boost-1.70-and-higher.-.zip

@simonzgx
Copy link

simonzgx commented Feb 1, 2020

It working okay for me! Thanks a lot!

@dxtkdxtk
Copy link

dxtkdxtk commented Feb 5, 2020

Thanks! It works

@barsnick
Copy link

Have you instead tried the two commits on the "develop" branch, which were committed/merged there in April 2019?:
c769c92
f810ca2
They are supposed to fix build with boost:::asio >= 1.70.

@aholzinger
Copy link
Author

Yes, that's it. Thank you very much!!!

@zaphoyd
Copy link
Owner

zaphoyd commented Apr 19, 2020

The fix for this issue has been available on the develop branch for some time and has now been published in release 0.8.2

@zaphoyd zaphoyd closed this as completed Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants