-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Redux 4.x #490
Conversation
I assume it's important to update |
@jacoporicare, |
Unfortunately I'm not a maintainer and I don't know what's the purpose of the |
let's wait for maintainer decision 👌 |
I like this change overall and using peerDependencies on the root package is a great idea, but shouldn't Also according to #460 being fixed, it seems that it's safe to declare Redux 4 support. |
Peer doesn’t mean optional, it only gives you a choice of a version you want to use. As far as I know almost every React library/component has react and react-dom as peer dependency. The truth is that I don’t know what is the purpose of package.json in the root folder... Edit: Now I see it’s a browser extension. Sorry, I use it only as an NPM package for easier store setup with enhancers. In that case I think there shouldn’t be any peerDependency at all as it’s a stand-alone “app”? |
Sorry if I was being misleading, I was referring to react-dom being in devDependencies but not peerDependencies. This means npm won't ensure react-dom is installed when this is used as a dependency of another package, which I think would break it because it's used to render the extension, not just in tests. We should add react-dom to peerDependencies or dependencies (probably the latter if it doesn't matter what version of react-dom is used by the underlying app). |
Cool thanks for making this consistent. I'm having second thoughts about if these need to be peer dependencies though. The redux-devtools-extension has a peer dependency on redux because it's used directly with an existing Redux app, which makes sense. However aren't the dependencies in the root package isolated to the extension (in which case they should probably not be peer dependencies)? If that's the case, it may be better to only use peer dependencies in redux-devtools-extension as we were before, which would involve reverting these changes to remotedev-redux-devtools-extension's package.json. |
@nickmccurdy - yeah now I think we need to change only I will make change |
@nickmccurdy That’s exactly what I was trying to say (in the EDIT section though) 😉. Glad we are on the same page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯I'm fine with this assuming there are no outstanding issues with Redux 4 support
There does appear to be an incompatibility with Redux 4 that needs to be fixed - this line is out of date:
See reduxjs/redux#2943 for discussion. |
Good catch. Is it a string starting with |
Feels a bit hacky, but yeah, that ought to work. |
seems we should not import actionTypes from redux. Just match the start of the string should work as expected. |
Any ETA on when this will be merged? |
I just spent a reasonable amount of time figuring out why my app was broken, until I got that it is because of this issue. Please merge this. |
@nickmccurdy just to answer your question: yes, it is a string with To sum everything up, it is possible to use a regex such as: Instead of using |
Is this project still being actively maintained? |
@nickmccurdy @zalmoxisus I apologize in advance for the spam, but this is still an issue in the v2.15.2 release of the Redux DevTools extension. Considering it's been approved and CI passed, I was hoping this would have been merged weeks ago. I really don't want to have to implement an alternative solution, because I think this extension is great. Please merge and release this fix! |
To be clear, my project is using Edit: I just tried removing the |
I know it’s not optimal but meanwhile you could use this fork: https://www.npmjs.com/package/redux-devtools-extension-sol
… 15 июня 2018 г., в 06:16, Joel Kanzelmeyer ***@***.***> написал(а):
To be clear, my project is using composeWithDevTools from the instructions outlined here. While I have v2.15.2 of the browser extension installed, the latest version of redux-devtools-extension available on npm is v2.13.2.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@nickmccurdy @zalmoxisus any update on this? |
Do we need another PR to bump the version and/or publish to npm? @nickmccurdy @zalmoxisus |
Published the npm package as |
It seems like there are still issues when using |
Having this during any build process with yarn: |
It seems like the Firefox extension hasn't been updated: https://addons.mozilla.org/en-US/firefox/addon/remotedev/ |
Redux 4 is out: https://github.com/reactjs/redux/releases/tag/v4.0.0
I didn't notice any breaking changes. 💯
I have also moved some packages topeerDependencies
, it allows to reduce bundle size and let user to choose which version of package use.am I missed something?