From 8976d18490188e058ad8b77843e4dfb70146e003 Mon Sep 17 00:00:00 2001 From: Filip Weiss Date: Sun, 16 Oct 2022 13:14:50 +0200 Subject: [PATCH] set: limit windows service size Signed-off-by: Filip Weiss --- keyring_windows.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/keyring_windows.go b/keyring_windows.go index 62dd366..738dac4 100644 --- a/keyring_windows.go +++ b/keyring_windows.go @@ -29,8 +29,14 @@ func (k windowsKeychain) Set(service, username, password string) error { return ErrSetDataTooBig } - // service may not exceed 32k - if len(service) > 1024*32 { + // service may not exceed 512 bytes (might need more testing) + if len(service) >= 512 { + return ErrSetDataTooBig + } + + // service may not exceed 32k but problems occur before that + // so we limit it to 30k + if len(service) > 1024*30 { return ErrSetDataTooBig }