Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to SpringBoot 3.x #186

Open
roskenet opened this issue Feb 19, 2024 · 2 comments
Open

Migration to SpringBoot 3.x #186

roskenet opened this issue Feb 19, 2024 · 2 comments
Assignees
Labels
bug dependencies Pull requests that update a dependency file

Comments

@roskenet
Copy link

When trying to use the starter in a SpringBoot 3.x project I found the following issues:

  1. The class for autoconfig is not processed (now META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports)

  2. The FlywayMigrator doesn't work anymore due to the change in the import of the PostConstruct annotation using jakarta.* instead of javax.* in SpringBoot 3.

Besides that I haven't found any issues yet (after importing the autoconfig class by hand).
Bumping up the SpringBoot version in nakadi-producer-starter breaks all the tests. (Needs a bit deeper trouble-shooting).

@ePaul ePaul added bug dependencies Pull requests that update a dependency file labels May 2, 2024
@ePaul
Copy link
Member

ePaul commented May 2, 2024

@roskenet Do you still intend to look into this so we can release a springboot-3-compatible version?

@wormangel
Copy link

@roskenet Do you still intend to look into this so we can release a springboot-3-compatible version?

I'm working on a PR right now, continuing where #189 left off and taking into account @roskenet's input above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants