Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for propagating opentracing span context in metadata #105

Open
brunoribeiro opened this issue Nov 26, 2018 · 3 comments
Open

Support for propagating opentracing span context in metadata #105

brunoribeiro opened this issue Nov 26, 2018 · 3 comments

Comments

@brunoribeiro
Copy link

Fahrschein already supports this, can we update the NakadiMetadata class to include the span ctx like in here

@brunoribeiro brunoribeiro changed the title Support for propagating opentracing span contexts in metadata Support for propagating opentracing span context in metadata Nov 26, 2018
@ePaul
Copy link
Member

ePaul commented Dec 17, 2018

Thanks for the suggestion.

I suppose what we actually want is to transport the span from when the event is passed to the library, not when it was passed to Nakadi (or maybe both?). Should we expose arguments for the span context map in the NakadiWriter interface, or get those implicitly by calling the OpenTracing implementation?

@ePaul
Copy link
Member

ePaul commented Feb 6, 2019

I started a sketch of an implementation in #115.

@ePaul
Copy link
Member

ePaul commented Aug 14, 2023

As mentioned in #115, a similar thing should be done with OpenTelemetry instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants