Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all HAR "entry" fields #48

Merged
merged 4 commits into from
Apr 25, 2019
Merged

Expose all HAR "entry" fields #48

merged 4 commits into from
Apr 25, 2019

Conversation

tortila
Copy link
Contributor

@tortila tortila commented Apr 25, 2019

Expose all HAR "entry" fields.

Closes #35

Description

Added a new property in the Request class to expose all the information about a single entry that was recorded in the HAR file, and that used to be ignored in our intermediate representation.

Types of Changes

  • New feature (non-breaking change which adds functionality)
  • Documentation / non-code

Review

Reviewers' checklist:

  • If this PR implements new flows or changes existing ones, are there
    good tests for these flows?
    If this PR rather removes flows, are the obsolete tests removed as well?
  • Is the documentation still up-to-date and exhaustive? This covers both
    technical (in source files) and functional (under docs/) documentation.
  • Is the changelog updated?
  • Does the new version number correspond to the actual changes from this PR?
    In doubt, refer to https://semver.org.

tortila added 3 commits April 17, 2019 17:41
Signed-off-by: Oliwia Zaremba <[email protected]>
Signed-off-by: Oliwia Zaremba <[email protected]>
Signed-off-by: Oliwia Zaremba <[email protected]>
@tortila tortila requested review from bmaher and thilp as code owners April 25, 2019 13:04
@zincr
Copy link

zincr bot commented Apr 25, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@tortila tortila force-pushed the har-entry-fields branch 2 times, most recently from 196927b to c111e21 Compare April 25, 2019 13:34
@tortila tortila added the work in progress This is being worked on. Do not merge yet! label Apr 25, 2019
@tortila
Copy link
Contributor Author

tortila commented Apr 25, 2019

This is WIP until the issue of failing Travis build is solved...

@tortila tortila force-pushed the har-entry-fields branch 2 times, most recently from 47c84a2 to d1fabc3 Compare April 25, 2019 14:06
Signed-off-by: Oliwia Zaremba <[email protected]>
@tortila
Copy link
Contributor Author

tortila commented Apr 25, 2019

Travis build is now back to normal with a simple workaround of downgrading pip. I will follow up in the original issue or create a new one once I know the exact way to reproduce the error. This PR is now ready to be reviewed 😄

Copy link
Member

@thilp thilp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@tortila tortila merged commit c23f291 into master Apr 25, 2019
@tortila tortila deleted the har-entry-fields branch April 25, 2019 15:04
@tortila tortila removed the work in progress This is being worked on. Do not merge yet! label Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose all HAR "entry" fields in each corresponding Task2 instance
3 participants