Skip to content

fix: Ticks overlap #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 26, 2021
Merged

fix: Ticks overlap #124

merged 5 commits into from
Jan 26, 2021

Conversation

NadjibSb
Copy link
Contributor

closes #115

@netlify
Copy link

netlify bot commented Jan 25, 2021 •
edited
Loading

Deploy preview for amazing-kilby-d9c1d7 ready!

Built with commit e6890fa

https://deploy-preview-124--amazing-kilby-d9c1d7.netlify.app

@targos
Copy link
Member

targos commented Jan 25, 2021

There's a lot of similarity between the two changed pieces of code. Could you factor that out a bit ?

@NadjibSb
Copy link
Contributor Author

NadjibSb commented Jan 25, 2021 •
edited
Loading

There's a lot of similarity between the two changed pieces of code. Could you factor that out a bit ?

You mean between BottomAxis & TopAxis ? it's the same yes
Should I extract the code that calculate Ticks number as util func ? or what do u suggest

@targos
Copy link
Member

targos commented Jan 25, 2021

Should I extract the code that calculate Ticks number as util func ?

Yes, please.

@targos targos merged commit ee12c40 into zakodium-oss:master Jan 26, 2021
@NadjibSb NadjibSb deleted the fix/tocks-optimization branch January 26, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maasencioh maasencioh maasencioh left review comments

@targos targos targos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ticks optimizations
3 participants
@NadjibSb @targos @maasencioh