fix: no default axis hooks bug

[wadjih-bencheikh18]

closes : #423

[netlify]

✅ Deploy Preview for react-plot ready!

Name	Link
🔨 Latest commit	a31c862
🔍 Latest deploy log	https://app.netlify.com/sites/react-plot/deploys/62bae2aec439bd0008e85adc
😎 Deploy Preview	https://deploy-preview-424--react-plot.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[targos]

Do we already have a story with this case? If not, can you add one?

[wadjih-bencheikh18]

Do we already have a story with this case? If not, can you add one?

the problem is in zakodium-oss/react-science#166

https://deploy-preview-166--analysis-ui-components.netlify.app/storybook/?path=/story/layout-measurementexplorer--control choose xVariable : "t"

[wadjih-bencheikh18]

i will try to create a story with the problem

[wadjih-bencheikh18]

@targos story added

[targos]

How can I reproduce the problem with the story? I tried to add a log when the value is undefined but nothing happens.

[targos]

I think it would be better to show the bug with a very simple story instead of this one.

[wadjih-bencheikh18]

I think it would be better to show the bug with a very simple story instead of this one.

the problem happend while changing the data after the plot loaded so i added a story where u can change horizantal and vertical variables

[wadjih-bencheikh18]

the bug always happend if we revert this modification 2aac582

[targos]

But for me this is not the correct fix. The crosshair doesn't work as expected.

[wadjih-bencheikh18]

But for me this is not the correct fix. The crosshair doesn't work as expected.

Sorry, i didn't notice that,I will check

[wadjih-bencheikh18]

@targos i found the problem and fix it
the thing that hooks were not genralized to use with no default axis variables

• i added DualAxisOptions in useAxisZoom to fix the problem
• convertStrings changes reverted (Logically, the case wouldn't happen)

[targos]

Vertical zoom doesn't work (it's horizontal), but apart from that, good job!
https://deploy-preview-424--react-plot.netlify.app/?path=/story/examples-measurement--measurement&args=xAxis:a;yAxis:t;hook:Vertical+Zoom

[wadjih-bencheikh18]

Vertical zoom doesn't work (it's horizontal)

Sorry about that , it's fixed now