Stop note map simulation if not visible#4183
Closed
FliegendeWurst wants to merge 1 commit intoTriliumNext:masterfrom
Closed
Stop note map simulation if not visible#4183FliegendeWurst wants to merge 1 commit intoTriliumNext:masterfrom
FliegendeWurst wants to merge 1 commit intoTriliumNext:masterfrom
Conversation
FliegendeWurst
commented
Aug 18, 2023
| } else { | ||
| const activeChild = this.getActiveRibbonWidget(); | ||
| if (activeChild) { | ||
| activeChild.handleEvent('deactivated', {}); |
Member
Author
There was a problem hiding this comment.
I am using a new event here since I did not find any existing mechanism to shut down a widget.
Contributor
There was a problem hiding this comment.
Have you tried cleanup() method in TypeWidget (inherited in NoteMapTypeWidget)? Seems to me it could be used for this. Although it would not work for Ribbon specifically ...
Member
Author
There was a problem hiding this comment.
It doesn't matter as much for the Ribbon widget, but could still be relevant for cases like #2608
FliegendeWurst
commented
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix, Trilium will be sluggish for a while (usually less than a minute) after closing a large note map.