Run zip import in a transaction.#3031
Closed
losfair wants to merge 1 commit intoTriliumNext:masterfrom
Closed
Conversation
Contributor
|
Hi, in general having transactional import would be beneficial. But one significant problem is that this approach forces the import mechanism to first read the whole ZIP into memory and removes the streaming aspect from the equation. This will cause problems when importing large ZIPs. |
Can't you just add more swap then or memory? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On SQLite VFSes where transaction start and commit are high-latency operations, this improves ZIP import performance a lot. Should help under the default settings too, as transaction commit involves at least one
fsync.With mvsqlite this reduces the time for importing
demo.zipfrom tens of seconds to ~0.6sec.Related: #3029