Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor contexts, instead map spacing methods directly to notes #3

Closed
zachmueller opened this issue Sep 27, 2024 · 0 comments
Closed
Labels
enhancement New feature or request

Comments

@zachmueller
Copy link
Owner

Need to stay mindful of any users that may have relied on contexts in its original form and ensure any code changes here properly deduce old style mapping of spacing methods to the new style. This means first trying to parse out the frontmatter properties in the new style, falling back to old settings and mappings between Contexts and SpacingMethods, if they exist, then further falling back to the "default" SpacingMethod (i.e., the first in the list).

Lots to think through here first before moving forward with any changes. How should I delineate between contexts vs spacing methods applied to a given note? How to handle if a user renames an existing spacing method, should I have it run an update to the frontmatter for all affected notes? Parse more thoughts out from my notes on this topic.

Minor changes required as part of this: remove the dropdown input from the Contexts section (since those no longer would get mapped to a specific spacing method). Set contexts.spacingMethodName setting to be optional and put that on path to deprecating the setting entirely.

@zachmueller zachmueller added the enhancement New feature or request label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant