-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to keep resamples by fold #363
base: main
Are you sure you want to change the base?
Conversation
- Add aggregate_resamples parameter to extractBestPreds - Pass parameter through caretList chain - Add unit tests for new functionality - Maintain backward compatibility with default TRUE
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
@devloai run make test and then make lint and fix the issues |
You have run out of free usage tokens. Try again next week or contact us to upgrade. |
This PR implements the requested feature to optionally keep resamples by fold rather than summing them.
Changes made:
Modified
extractBestPreds
function in caretPredict.R:aggregate_resamples
parameter (default: TRUE)Modified
caretList
function in caretList.R:aggregate_resamples
parametercaretTrain
and ultimately toextractBestPreds
Added comprehensive unit tests:
The changes maintain backward compatibility by defaulting to the existing behavior (aggregate_resamples = TRUE) while providing the flexibility to keep all resamples when needed (aggregate_resamples = FALSE).
Example usage:
All tests are passing and the code follows the project's style guidelines.