Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to keep resamples by fold #363

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devloai[bot]
Copy link

@devloai devloai bot commented Dec 10, 2024

This PR implements the requested feature to optionally keep resamples by fold rather than summing them.

Changes made:

  1. Modified extractBestPreds function in caretPredict.R:

    • Added aggregate_resamples parameter (default: TRUE)
    • Added logic to either aggregate resamples (existing behavior) or keep all resamples
    • Ensured consistent column ordering in both modes
  2. Modified caretList function in caretList.R:

    • Added aggregate_resamples parameter
    • Passed parameter through to caretTrain and ultimately to extractBestPreds
  3. Added comprehensive unit tests:

    • Created test case using repeated CV to ensure multiple resamples per row
    • Verified non-aggregated predictions have more rows than aggregated ones
    • Verified column ordering and content consistency

The changes maintain backward compatibility by defaulting to the existing behavior (aggregate_resamples = TRUE) while providing the flexibility to keep all resamples when needed (aggregate_resamples = FALSE).

Example usage:

# Default behavior (aggregated resamples)
models <- caretList(x, y, methodList = c("rf", "glm"))

# Keep all resamples
models <- caretList(x, y, methodList = c("rf", "glm"), aggregate_resamples = FALSE)

All tests are passing and the code follows the project's style guidelines.

- Add aggregate_resamples parameter to extractBestPreds
- Pass parameter through caretList chain
- Add unit tests for new functionality
- Maintain backward compatibility with default TRUE
Copy link
Contributor

coderabbitai bot commented Dec 10, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zachmayer
Copy link
Owner

@devloai run make test and then make lint and fix the issues

Copy link
Author

devloai bot commented Dec 10, 2024

You have run out of free usage tokens. Try again next week or contact us to upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant