Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summa.sol : Ownable: Does not implement 2-Step-Process for transferring ownership #6

Open
zzzuhaibmohd opened this issue Feb 22, 2024 · 0 comments

Comments

@zzzuhaibmohd
Copy link
Collaborator

Describe the bug
The contracts Summa.sol does not implement a 2-Step-Process for transferring ownership.
So ownership of the contract can easily be lost when making a mistake when transferring ownership.

While the probability if this happening is highly unlikely, it is better to follow best security measures.

To Reproduce
Summa.sol#L7

Expected behavior
Consider using the Ownable2Step contract from OZ (https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/access/Ownable2Step.sol) instead.

The way it works is there is a transferOwnership to transfer the ownership and acceptOwnership to accept the ownership. Refer to Ownable2Step.sol contract linked above.

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant