Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low Audio Quality #1294

Open
4 tasks done
RGBCube opened this issue Jun 19, 2024 · 15 comments
Open
4 tasks done

Low Audio Quality #1294

RGBCube opened this issue Jun 19, 2024 · 15 comments
Labels
bug Something isn't working

Comments

@RGBCube
Copy link

RGBCube commented Jun 19, 2024

Checklist

  • I am able to reproduce the bug with the latest debug version.
  • I've checked that there is no open or closed issue about this bug.
  • This issue contains only one bug.
  • The title of this issue accurately describes the bug.

Steps to reproduce the bug

Listen to any song in InnerTune and then on ViMusic and notice the quality difference.

Expected behavior

Better Quality music.

Actual behavior

Low and murky quality music.

InnerTune version

0.5.3

Android version

12

Additional information

Even when the Audio Quality setting is set to High, InnerTune still fetches murky audio. I have tried the same song in ViMusic, and there it is definitely higher quality. Maybe the YouTube Music API is giving InnerTune low quality music because of a user agent or any identifiable information?

This could be fixed by copying the ViMusic downloader implementation over with minimal changes. Hopefully then audio quality will be better for High Quality mode.

@RGBCube RGBCube added the bug Something isn't working label Jun 19, 2024
@RGBCube
Copy link
Author

RGBCube commented Jun 19, 2024

Could the low quality be related with logging into one's YouTube Music account? Because after logging out the quality is no longer low. Weird?

@RGBCube
Copy link
Author

RGBCube commented Jun 26, 2024

Actually nevermind, it's low even without logging in now

@z-huang
Copy link
Owner

z-huang commented Aug 4, 2024

InnerTune gets the highest quality possible if you set quality to high. The highest quality is determined by YouTube. Can you provide information about the quality difference between InnerTune and ViMusic?

@RGBCube
Copy link
Author

RGBCube commented Aug 4, 2024

InnerTune gets the highest quality possible if you set quality to high. The highest quality is determined by YouTube. Can you provide information about the quality difference between InnerTune and ViMusic?

You are able to hear it, it sounds murky compared to ViMusic. The YouTube API might be checking for user agents or anything that signals that the client is not authentic and if it isn't, it might be serving lower quality music to them (only sometimes, for some reason).

This doesn't happen with ViMusic, could you check what it does differently (compared to InnerTune) which lets it get the highest quality music all the time?

@z-huang
Copy link
Owner

z-huang commented Aug 4, 2024

Statistically, InnerTune and ViMusic can both get 140~150kbps quality. Methodologically, InnerTune and ViMusic use a very similar method. You may need to provide more information, thanks.

@darkza
Copy link

darkza commented Aug 5, 2024

is there any option like "statistics for interested" so that you can see what quality actually is playing?

@z-huang
Copy link
Owner

z-huang commented Aug 7, 2024

In the player screen, click "..." at the bottom, and click "Details".

@RGBCube
Copy link
Author

RGBCube commented Aug 8, 2024

In the player screen, click "..." at the bottom, and click "Details".

Screenshot_20240808-192701_InnerTune.png

Screenshot_20240808-192643_InnerTune.png

Screenshot_20240808-192714_InnerTune.png

Most of the time I get around 50kbps, only rarely 150ish.

However on ViMusic I always get the highest. Are you sure all the info served to the YouTube API is similar between ViMusic and InnerTune?

@frutejuise
Copy link

On the same song I get 134kbps, 50s is extremely low
Screenshot_20240814-215934.png

@frutejuise
Copy link

Screenshot_20240814-220137.png

@frutejuise
Copy link

I don't think I've ever had a problem with the quality, my only thought is yours could be on auto?

@RGBCube
Copy link
Author

RGBCube commented Aug 15, 2024

I don't think I've ever had a problem with the quality, my only thought is yours could be on auto?

nope, just checked and it is on High. I also have Audio Normalization enabled, but that shouldn't affect anything should it?

@frutejuise
Copy link

Not sure.

@RGBCube
Copy link
Author

RGBCube commented Aug 26, 2024

Hmm, I think I've figured it out. Something is persisting that makes InnerTune fetch low quality audio when you listen to a song on auto/low quality, then switch to high. Clearing the audio cache doesn't fix this, which is the problem here. @z-huang could you look into this? Should be an easy fix.

@ganairm
Copy link

ganairm commented Sep 5, 2024

i have the same issue... after trying to log in to youtube music... it was working perfectly fine, but then as soon as i logged in, some songs are fetched in lower bit-rate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants