From 3b15879a926bbafaef2be103f46fe10c6abea38a Mon Sep 17 00:00:00 2001 From: Tim Yung Date: Wed, 29 May 2024 22:50:47 -0700 Subject: [PATCH] Revert "Change to content hash for RN canary VERSION strings (#28582)" This reverts commit cb076b593cec3a92338958f58468cce19cb8f0d9. --- scripts/rollup/build-all-release-channels.js | 32 ++++++++++++-------- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/scripts/rollup/build-all-release-channels.js b/scripts/rollup/build-all-release-channels.js index fed1bb8c460ca..b7427d135bcc6 100644 --- a/scripts/rollup/build-all-release-channels.js +++ b/scripts/rollup/build-all-release-channels.js @@ -173,17 +173,25 @@ function processStable(buildDir) { ); } - [ - buildDir + '/react-native/implementations/', - buildDir + '/facebook-react-native/', - ].forEach(reactNativeBuildDir => { - if (fs.existsSync(reactNativeBuildDir)) { - updatePlaceholderReactVersionInCompiledArtifacts( - reactNativeBuildDir, - ReactVersion + '-' + canaryChannelLabel + '-%FILEHASH%' - ); + const reactNativeBuildDir = buildDir + '/react-native/implementations/'; + if (fs.existsSync(reactNativeBuildDir)) { + const hash = crypto.createHash('sha1'); + for (const fileName of fs.readdirSync(reactNativeBuildDir).sort()) { + const filePath = reactNativeBuildDir + fileName; + const stats = fs.statSync(filePath); + if (!stats.isDirectory()) { + hash.update(fs.readFileSync(filePath)); + } } - }); + updatePlaceholderReactVersionInCompiledArtifacts( + reactNativeBuildDir, + ReactVersion + + '-' + + canaryChannelLabel + + '-' + + hash.digest('hex').slice(0, 8) + ); + } // Update remaining placeholders with canary channel version updatePlaceholderReactVersionInCompiledArtifacts( @@ -354,11 +362,9 @@ function updatePlaceholderReactVersionInCompiledArtifacts( for (const artifactFilename of artifactFilenames) { const originalText = fs.readFileSync(artifactFilename, 'utf8'); - const fileHash = crypto.createHash('sha1'); - fileHash.update(originalText); const replacedText = originalText.replaceAll( PLACEHOLDER_REACT_VERSION, - newVersion.replace(/%FILEHASH%/g, fileHash.digest('hex').slice(0, 8)) + newVersion ); fs.writeFileSync(artifactFilename, replacedText); }