Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPX for HTTP/2 #8

Open
dush opened this issue May 16, 2019 · 4 comments
Open

Use HTTPX for HTTP/2 #8

dush opened this issue May 16, 2019 · 4 comments

Comments

@dush
Copy link

dush commented May 16, 2019

https://gitlab.com/honeyryderchuck/httpx is ruby HTTP library with support for HTTP/2 without libcurl dependency.

@yuki24
Copy link
Owner

yuki24 commented May 16, 2019

I have seen some critical issues in the http-2 gem (internally used by httpx) in the past, most notably igrigorik/http-2#73 and igrigorik/http-2#132. There is also igrigorik/http-2#144 that makes me a bit hesitant to use it as a dependency.

While libcurl and nghttp2 are not trivial dependencies, they have been used by billions of devices world-wide and a lot more reliable than http-2 (or almost all Ruby implementations). In the future, we should switch to a pure-Ruby implementation, but today is not the time to make the move.

@yuki24 yuki24 closed this as completed May 16, 2019
@HoneyryderChuck
Copy link

I've only seen this now. I'm the httpx maintainer. I've forked the http-2 gem over 3 years ago, and made it pass all http/2 compliance checks, and it has been pretty solid for years now.

@yuki24
Copy link
Owner

yuki24 commented Dec 4, 2022

It's been more than 3 years since the last activity and it's probably a good idea to re-visit this.

I'm not sure how long it will take though - I have been away from Android related projects in Ruby and I'm not even sure what people do to send push notifications. I'll re-open this issue so we know the conversation is up in the air.

@yuki24 yuki24 reopened this Dec 4, 2022
@HoneyryderChuck
Copy link

I can fill in the information gaps where needed. I gave a look at the readme, and it seems you're using net-http-persistent. Httpx supports both http 1 and 2, and ships with a persistent plugin that should deliver the same functionality. By replacing one with the other, you could remove the libcurl based implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants