Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support conversion of implicit spec types in rspec-rails #57

Closed
yujinakayama opened this issue Apr 9, 2014 · 4 comments
Closed

Support conversion of implicit spec types in rspec-rails #57

yujinakayama opened this issue Apr 9, 2014 · 4 comments

Comments

@yujinakayama
Copy link
Owner Author

@myronmarston Currently I'm implementing this conversion, but I'm not sure whether this conversion should be enabled by default since the implicit mixins still can be considered as the default behavior in rspec-rails 3.0:

What do you think?

@myronmarston
Copy link

Setting the type explicitly (even if the config.infer_spec_type_from_file_location! option is used) causes no problems and will make it easier for the user to stop using that config option in the future if they want, so I think it's probably worth while to do it anyway.

@cupakromer, what do you think? Also, as @yujinakayama pointed out, there's some docs and templates we should probably update :).

@yujinakayama yujinakayama changed the title Consider supporting conversion of implicit example group mixin in rspec-rails Support conversion of implicit example group mixin in rspec-rails May 10, 2014
@yujinakayama
Copy link
Owner Author

@myronmarston Thanks. It makes sense. I'll make the conversion enabled by default.

@cupakromer
Copy link

I agree with turning it on by default. Agreed, a few more updates need to be made in rspec-rails for this.

@yujinakayama yujinakayama changed the title Support conversion of implicit example group mixin in rspec-rails Support conversion of implicit spec types in rspec-rails May 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants