-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support conversion of implicit spec types in rspec-rails #57
Comments
@myronmarston Currently I'm implementing this conversion, but I'm not sure whether this conversion should be enabled by default since the implicit mixins still can be considered as the default behavior in rspec-rails 3.0:
What do you think? |
Setting the type explicitly (even if the @cupakromer, what do you think? Also, as @yujinakayama pointed out, there's some docs and templates we should probably update :). |
@myronmarston Thanks. It makes sense. I'll make the conversion enabled by default. |
I agree with turning it on by default. Agreed, a few more updates need to be made in rspec-rails for this. |
infer_spec_type_from_file_location!
when upgrading rspec/rspec-rails#1004The text was updated successfully, but these errors were encountered: