Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RiseLoader throws DomException on iOS (5) Safari #27

Open
drywolf opened this issue Jun 24, 2016 · 1 comment
Open

RiseLoader throws DomException on iOS (5) Safari #27

drywolf opened this issue Jun 24, 2016 · 1 comment

Comments

@drywolf
Copy link

drywolf commented Jun 24, 2016

Hi,

I just found a small CSS typo that crashes halogen on iOS Safari.
See the code below:

/**
 * @type {Object}
 */
var keyframesEven = {
    '0%': {
        transform: 'scale(1.1)'
    },
    '25': { // <----------------------- Percent sign missing (causes DOM exception)
        transform: 'translateY(-' + riseAmount + 'px)'
    },
    '50%': {
        transform: 'scale(0.4)'
    },
    '75%': {
        transform: 'translateY(' + riseAmount + 'px)'
    },
    '100%': {
        transform: 'translateY(0) scale(1.0)'
    }
};

/**
 * @type {Object}
 */
var keyframesOdd = {
    '0%': {
        transform: 'scale(0.4)'
    },
    '25': { // <----------------------- Percent sign missing (causes DOM exception)
        transform: 'translateY(' + riseAmount + 'px)'
    },
    '50%': {
        transform: 'scale(1.1)'
    },
    '75%': {
        transform: 'translateY(-' + riseAmount + 'px)'
    },
    '100%': {
        transform: 'translateY(0) scale(0.75)'
    }
};

Once I add the percent signs, the error is fixed.

Regards

@kirillDanshin
Copy link

hi. just FYI, it's fixed in halogenium, the maintained halogen fork. also #24 fixed too. rendering in chrome/opera/firefox fixed too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants