Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: remove duplicate functions in two SPH backend PRs #4991

Open
nastasha-w opened this issue Sep 14, 2024 · 1 comment · May be fixed by #4783
Open

CLN: remove duplicate functions in two SPH backend PRs #4991

nastasha-w opened this issue Sep 14, 2024 · 1 comment · May be fixed by #4783

Comments

@nastasha-w
Copy link
Contributor

TODO

After merging two PRs with fixes for the SPH projection and Ray backends (#4939 and #4783), import some functions (_cubicspline_python and _integrate_kernel) for the Ray tests from yt/testing.py (as used in yt/geometry/coordinates/tests/test_sph_pixelization.py in the sph_proj_backend branch) instead of defining them in their own test script (yt/data_objects/tests/test_rays.py in the issue4781_sph_ray_dl branch). This issue is a reminder to clean those duplicate definitions up after both PRs are merged.
@nastasha-w nastasha-w linked a pull request Sep 19, 2024 that will close this issue
Open
2 tasks
@nastasha-w
Copy link
Contributor Author

Since #4939 has been merged into main, I merged the newest main version into the #4783 branch, and removed the duplicate functions there in a new commit.
I think we can close this issue after that PR is merged.

@chrishavlin chrishavlin linked a pull request Sep 19, 2024 that will close this issue
Ray object dl for SPH data: interpolate kernel table for (b/hsml)**2 instead of b/hsml #4783
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ray object dl for SPH data: interpolate kernel table for (b/hsml)**2 instead of b/hsml nastasha-w/yt
1 participant
@nastasha-w