Skip to content

Conversation

@iceychris
Copy link
Contributor

Hey, it's me again 😄

This implements basic support for the web platform by creating a shared interface and coding the web part in dart.

The code doesn't respect sampleRate and bufferSize yet.

While setting sampleRate should be possible, IMO a better approach would be to add a function (e.g. getRecordingParameters(...)) for querying the default sampleRate and bufferSize on each Platform separately.

What do you think?

@ysak-y
Copy link
Owner

ysak-y commented Aug 16, 2021

Hi, thank you for your contribution!

At first, I think package should provide same interface to each platform. So I want to modify all if change interface. In short, I want to separate your suggestion to Implement web platform and Modify interface.

So I hope you

  • Implement for web platform with current interface (= supports sampleRate and bufferSize arguments)
  • Propose new interface by issue (I want to know your motivation for new interface more)
  • Modify code of each platform to change to new interface after discussion (Mainly I'll implement it)

or

  • Propose new interface by issue (I want to know your motivation for new interface more)
  • Modify code of each platform to change to new interface after discussion (Mainly I'll implement it)
  • Implement for web platform with new interface

Is that fine with you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants