From 616c51bba1177685a39b0f147f7639bebc67497b Mon Sep 17 00:00:00 2001 From: Yang Shi Date: Tue, 28 Apr 2020 14:47:16 -0700 Subject: [PATCH] Fixed Install page history broken (#18182) * fix install option block history broke * when history goes back, avoid button default css blue outline * use appropriate parameter name * format scss change --- docs/static_site/src/_sass/minima/_getting_started.scss | 5 +++++ docs/static_site/src/assets/js/options.js | 7 +++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/docs/static_site/src/_sass/minima/_getting_started.scss b/docs/static_site/src/_sass/minima/_getting_started.scss index 550ddaaf30db..f6775927cdcb 100644 --- a/docs/static_site/src/_sass/minima/_getting_started.scss +++ b/docs/static_site/src/_sass/minima/_getting_started.scss @@ -172,6 +172,11 @@ ul.dropdown-content { background-color: $color-mxnet; color: $grey-color-light; } + + &:focus { + outline: 0; + } + } diff --git a/docs/static_site/src/assets/js/options.js b/docs/static_site/src/assets/js/options.js index 9cd944fe3a52..5d3f8d201944 100644 --- a/docs/static_site/src/assets/js/options.js +++ b/docs/static_site/src/assets/js/options.js @@ -45,7 +45,7 @@ $(document).ready(function () { } } - function setSelects(urlParams) { + function setSelects(urlParams, dontPushState) { let queryString = '?'; $('button.opt').removeClass('active'); if (urlParams.get('version')) { @@ -87,7 +87,7 @@ $(document).ready(function () { showContent(); - if (window.location.href.indexOf("/get_started") >= 0) { + if (window.location.href.indexOf("/get_started") >= 0 && !dontPushState) { history.pushState(null, null, queryString); } } @@ -129,5 +129,8 @@ $(document).ready(function () { $('.opt-group').on('click', '.opt', setContent); $('.install-widget').css("visibility", "visible"); $('.install-content').css("visibility", "visible"); + $(window).on('popstate', function(){ + setSelects(urlSearchParams(window.location.search), true); + }); });