Merge pull request #168 from yowainwright/add-test-for-module-order

fix: add test for --module flag order

Author: yowainwright

index.js

@@ -25,35 +25,31 @@ program
   .version(pkg.version)
   .argument(
     '[ecmaVersion]',
-    'ecmaVersion to check files against. Can be: es3, es4, es5, es6/es2015, es7/es2016, es8/es2017, es9/es2018, es10/es2019'
-  )
-  .argument(
-    '[files...]',
-    'a glob of files to to test the EcmaScript version against'
+    'ecmaVersion to check files against. Can be: es3, es4, es5, es6/es2015, es7/es2016, es8/es2017, es9/es2018, es10/es2019',
   )
+  .argument('[files...]', 'a glob of files to to test the EcmaScript version against')
   .option('--module', 'use ES modules')
-  .option(
-    '--allow-hash-bang',
-    'if the code starts with #! treat it as a comment'
-  )
+  .option('--allow-hash-bang', 'if the code starts with #! treat it as a comment')
   .option('--not <files>', 'folder or file names to skip')
   .option('--no-color', 'disable use of colors in output')
   .option('-v, --verbose', 'verbose mode: will also output debug messages')
   .option('--quiet', 'quiet mode: only displays warn and error messages')
   .option(
     '--silent',
-    'silent mode: does not output anything, giving no indication of success or failure other than the exit code'
+    'silent mode: does not output anything, giving no indication of success or failure other than the exit code',
   )
   .action((ecmaVersionArg, filesArg, options) => {
     const logger = winston.createLogger()
-    logger.add(new winston.transports.Console({
-      silent: options.silent,
-      level: options.verbose ? 'silly' : options.quiet ? 'warn' : 'info',
-      format: winston.format.combine(
-        ...supportsColor.stdout ? [winston.format.colorize()] : [],
-        winston.format.simple()
-      )
-    }))
+    logger.add(
+      new winston.transports.Console({
+        silent: options.silent,
+        level: options.verbose ? 'silly' : options.quiet ? 'warn' : 'info',
+        format: winston.format.combine(
+          ...(supportsColor.stdout ? [winston.format.colorize()] : []),
+          winston.format.simple(),
+        ),
+      }),
+    )
 
     const configFilePath = path.resolve(process.cwd(), '.escheckrc')
 
@@ -63,34 +59,22 @@ program
      * - If one exists, default to those options
      * - If no command line arguments are passed in
      */
-    const config = fs.existsSync(configFilePath)
-      ? JSON.parse(fs.readFileSync(configFilePath))
-      : {}
-    const expectedEcmaVersion = ecmaVersionArg
-      ? ecmaVersionArg
-      : config.ecmaVersion
-    const files =
-      filesArg && filesArg.length ? filesArg : [].concat(config.files)
+    const config = fs.existsSync(configFilePath) ? JSON.parse(fs.readFileSync(configFilePath)) : {}
+    const expectedEcmaVersion = ecmaVersionArg ? ecmaVersionArg : config.ecmaVersion
+    const files = filesArg && filesArg.length ? filesArg : [].concat(config.files)
     const esmodule = options.module ? options.module : config.module
-    const allowHashBang = options.allowHashBang
-      ? options.allowHashBang
-      : config.allowHashBang
-    const pathsToIgnore =
-      options.not
-        ? options.not.split(',')
-        : [].concat(config.not || [])
+    const allowHashBang = options.allowHashBang ? options.allowHashBang : config.allowHashBang
+    const pathsToIgnore = options.not ? options.not.split(',') : [].concat(config.not || [])
 
     if (!expectedEcmaVersion) {
       logger.error(
-        'No ecmaScript version passed in or found in .escheckrc. Please set your ecmaScript version in the CLI or in .escheckrc'
+        'No ecmaScript version passed in or found in .escheckrc. Please set your ecmaScript version in the CLI or in .escheckrc',
       )
       process.exit(1)
     }
 
     if (!files || !files.length) {
-      logger.error(
-        'No files were passed in please pass in a list of files to es-check!'
-      )
+      logger.error('No files were passed in please pass in a list of files to es-check!')
       process.exit(1)
     }
 
@@ -151,9 +135,7 @@ program
         ecmaVersion = '2021'
         break
       default:
-        logger.error(
-          'Invalid ecmaScript version, please pass a valid version, use --help for help'
-        )
+        logger.error('Invalid ecmaScript version, please pass a valid version, use --help for help')
         process.exit(1)
     }
 
@@ -172,10 +154,7 @@ program
     const filterForIgnore = (globbedFiles) => {
       if (expandedPathsToIgnore && expandedPathsToIgnore.length > 0) {
         const filtered = globbedFiles.filter(
-          (filePath) =>
-            !expandedPathsToIgnore.some((ignoreValue) =>
-              filePath.includes(ignoreValue)
-            )
+          (filePath) => !expandedPathsToIgnore.some((ignoreValue) => filePath.includes(ignoreValue)),
         )
         return filtered
       }
@@ -198,38 +177,31 @@ program
       const globbedFiles = glob.sync(pattern, globOpts)
 
       if (globbedFiles.length === 0) {
-        logger.error(
-          `ES-Check: Did not find any files to check for ${pattern}.`
-        )
+        logger.error(`ES-Check: Did not find any files to check for ${pattern}.`)
         process.exit(1)
       }
 
       const filteredFiles = filterForIgnore(globbedFiles)
 
       filteredFiles.forEach((file) => {
         const code = fs.readFileSync(file, 'utf8')
-
         logger.debug(`ES-Check: checking ${file}`)
         try {
           acorn.parse(code, acornOpts)
         } catch (err) {
-          logger.debug(
-            `ES-Check: failed to parse file: ${file} \n - error: ${err}`
-          )
+          logger.debug(`ES-Check: failed to parse file: ${file} \n - error: ${err}`)
           const errorObj = {
             err,
             stack: err.stack,
-            file
+            file,
           }
           errArray.push(errorObj)
         }
       })
     })
 
     if (errArray.length > 0) {
-      logger.error(
-        `ES-Check: there were ${errArray.length} ES version matching errors.`
-      )
+      logger.error(`ES-Check: there were ${errArray.length} ES version matching errors.`)
       errArray.forEach((o) => {
         logger.info(`
           ES-Check Error:

package.json

@@ -13,7 +13,7 @@
   "scripts": {
     "commit": "git-cz",
     "commit-msg": "commitlint --edit $1",
-    "husky-setup": "if [[ ! -d /.husky/commit-msg ]]; then (husky install && pnpm husky-setup:commit-msg && pnpm husky-setup:post-merge && pnpm husky-setup:pre-commit); fi",
+    "husky-setup": "path-exists .husky/commit-msg || (husky install && pnpm husky-setup:commit-msg && pnpm husky-setup:post-merge && pnpm husky-setup:pre-commit)",
     "husky-setup:commit-msg": "npx husky add .husky/commit-msg 'pnpm run commit-msg'",
     "husky-setup:post-merge": "npx husky add .husky/post-merge 'pnpm run setup'",
     "husky-setup:pre-commit": "npx husky add .husky/pre-commit 'pnpm run pre-commit'",
@@ -49,6 +49,7 @@
     "husky": "^8.0.1",
     "mocha": "^10.0.0",
     "nyc": "^15.1.0",
+    "path-exists-cli": "^2.0.0",
     "prettier": "^2.5.1",
     "release-it": "^15.1.3"
   },