Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Account Deletion and Password Change to CLI Commands #982

Closed
chacha912 opened this issue Aug 27, 2024 · 1 comment · Fixed by #983
Closed

Add Account Deletion and Password Change to CLI Commands #982

chacha912 opened this issue Aug 27, 2024 · 1 comment · Fixed by #983
Assignees
Labels
enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers

Comments

@chacha912
Copy link
Contributor

What would you like to be added:

Currently, our CLI supports login and logout commands:
https://yorkie.dev/docs/cli#login

$ yorkie login -u <username> -p <password> --rpc-addr api.yorkie.dev:443
$ yorkie logout

With the recent development of ChangePassword and DeleteAccount APIs on the server side(#849), we should extend our CLI functionality to include these features.

Implementation Details

  • Integrate with the newly developed server APIs: ChangePassword and DeleteAccount.
  • Implement proper error handling and user feedback.
  • Ensure secure handling of sensitive information (passwords).
  • Update CLI documentation to reflect these new commands.

Security Considerations

  • For the delete account command, consider implementing a confirmation step to prevent accidental deletions.
  • Ensure all communications with the server for these sensitive operations are properly encrypted.

Why is this needed:

CLI users can manage their accounts without switching to a different interface, streamlining their workflow.

@krapie
Copy link
Member

krapie commented Aug 27, 2024

Currently, account deletion does not performing cascading deletion over associated resources.
We might need to manually handle orphan resources after the account is removed.
#946

@github-staff github-staff deleted a comment from mayank785 Oct 23, 2024
@github-staff github-staff deleted a comment from mayank785 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

8 participants
@krapie @chacha912 @sigmaith and others