From fb1c2bccccc49925498dfeb27d286dc5031f5ed1 Mon Sep 17 00:00:00 2001 From: bannzai Date: Thu, 26 Nov 2020 15:25:10 +0900 Subject: [PATCH 1/2] More detailed error message with method arguments --- Sources/XcodeGenKit/PBXProjGenerator.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Sources/XcodeGenKit/PBXProjGenerator.swift b/Sources/XcodeGenKit/PBXProjGenerator.swift index ae765f1b..8cce6abf 100644 --- a/Sources/XcodeGenKit/PBXProjGenerator.swift +++ b/Sources/XcodeGenKit/PBXProjGenerator.swift @@ -370,13 +370,13 @@ public class PBXProjGenerator { func generateExternalTargetDependency(from: String, to target: String, in project: String, platform: Platform) throws -> (PBXTargetDependency, Target, PBXReferenceProxy) { guard let projectReference = self.project.getProjectReference(project) else { - fatalError("project not found") + fatalError("project '\(project)' not found") } let pbxProj = try getPBXProj(from: projectReference) guard let targetObject = pbxProj.targets(named: target).first else { - fatalError("target not found") + fatalError("target '\(target)' not found in project '\(project)'") } let projectFileReferenceIndex = self.pbxProj.rootObject! From 0db3c78914bd085d7c73093338cf25c1b211baa6 Mon Sep 17 00:00:00 2001 From: bannzai Date: Mon, 30 Nov 2020 17:14:27 +0900 Subject: [PATCH 2/2] Add pr title to CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index fc5565d6..ed6127e6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ #### Added - Support for building and running on Linux platforms. Tested for compatibility with Swift 5.3+ and Ubuntu 18.04. [#988](https://github.com/yonaskolb/XcodeGen/pull/988) @elliottwilliams - Add `useBaseInternationalization` to Project Spec Options to opt out of Base Internationalization. [#961](https://github.com/yonaskolb/XcodeGen/pull/961) @liamnichols +- More detailed error message with method arguments. [#990](https://github.com/yonaskolb/XcodeGen/pull/990) @bannzai #### Fixed - Fixed error message output for `minimumXcodeGenVersion`. [#967](https://github.com/yonaskolb/XcodeGen/pull/967) @joshwalker