Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: User Impersonation #299

Open
logan-bobo opened this issue Jun 11, 2024 · 3 comments
Open

Feature: User Impersonation #299

logan-bobo opened this issue Jun 11, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@logan-bobo
Copy link

Is your feature request related to a problem? Please describe.
Currently we are using Kor to produce a report of unused resources across our K8s infra. Our users need to escalate to an admin user via user impersonation to run high risk activities such as a PVC delete. Currently if we try to use the delete commands it does not work because Kor does not accept a --as admin flag

Describe the solution you'd like
Allow for a --as flag for running deletions from the Kor CLI

Describe alternatives you've considered
Currently I have got around this by running Kor and outputting the resources to be cleaned to json then iterating over a list of resources and the kubectl command to delete the resource. It would be great if we could remove this step and allow for user impersonation.

@logan-bobo
Copy link
Author

I am also willing to help out on this change and will attempt to push a PR if the maintainers think this to be a good idea 🫶

@yonahd yonahd added the enhancement New feature or request label Jun 11, 2024
@yonahd
Copy link
Owner

yonahd commented Jun 11, 2024

Hi @logan-bobo this is definitely a good feature.
I'm not super familiar with user impersonation so I'm not sure what the cost of adding and maintaining this would be. So I can't guarantee it will be added.

You're welcome to work on this and we can see what this requires, my feeling is this won't be too hard

@yonahd
Copy link
Owner

yonahd commented Aug 27, 2024

Hey @logan-bobo
Did you start any work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants