You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A recent update using "isSphere" instead of instanceof to check the type of a sphere object is causing runtime errors with older three.js (because isSphere is a recent addition: mrdoob/three.js#27395)
This seems like a minor reason to require a big version dependency bump, so maybe an alternative would be to use a hybrid solution (instanceof if isSphere is missing?)
Describe the bug
https://github.com/yomotsu/camera-controls/blob/dev/src/CameraControls.ts#L1987
A recent update using "isSphere" instead of instanceof to check the type of a sphere object is causing runtime errors with older three.js (because isSphere is a recent addition: mrdoob/three.js#27395)
Using this property, CameraControls should now specify three.js >= r160 (https://github.com/mrdoob/three.js/releases/tag/r160)
This seems like a minor reason to require a big version dependency bump, so maybe an alternative would be to use a hybrid solution (instanceof if isSphere is missing?)
#510
To Reproduce
Steps to reproduce the behavior:
Use fitToSphere function with three.js before r160
Code
No response
Live example
No response
Expected behavior
no errors, function runs as normal with older three.js OR version requirement bump in package.json
Screenshots or Video
No response
Device
No response
OS
No response
Browser
No response
The text was updated successfully, but these errors were encountered: